From 2ab6e985e356f0f3d8637d81630d191cc11b8806 Mon Sep 17 00:00:00 2001
From: Philipp Dormann <philipp@philippdormann.de>
Date: Mon, 28 Apr 2025 10:56:06 +0200
Subject: [PATCH] refactor: make Donation.donor optional

---
 src/models/actions/create/CreateDonation.ts | 5 +----
 src/models/entities/Donation.ts             | 4 +---
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/models/actions/create/CreateDonation.ts b/src/models/actions/create/CreateDonation.ts
index e70455e..4297b12 100644
--- a/src/models/actions/create/CreateDonation.ts
+++ b/src/models/actions/create/CreateDonation.ts
@@ -1,6 +1,5 @@
 import { IsInt, IsOptional, IsPositive } from 'class-validator';
 import { getConnection } from 'typeorm';
-import { DonorNotFoundError } from '../../../errors/DonorErrors';
 import { Donation } from '../../entities/Donation';
 import { Donor } from '../../entities/Donor';
 
@@ -14,6 +13,7 @@ export abstract class CreateDonation {
      */
     @IsInt()
     @IsPositive()
+    @IsOptional()
     donor: number;
 
     /**
@@ -33,9 +33,6 @@ export abstract class CreateDonation {
      */
     public async getDonor(): Promise<Donor> {
         const donor = await getConnection().getRepository(Donor).findOne({ id: this.donor });
-        if (!donor) {
-            throw new DonorNotFoundError();
-        }
         return donor;
     }
 }
\ No newline at end of file
diff --git a/src/models/entities/Donation.ts b/src/models/entities/Donation.ts
index f693d01..b9a6ef0 100644
--- a/src/models/entities/Donation.ts
+++ b/src/models/entities/Donation.ts
@@ -1,6 +1,5 @@
 import {
-  IsInt,
-  IsNotEmpty
+  IsInt
 } from "class-validator";
 import { Column, Entity, ManyToOne, PrimaryGeneratedColumn, TableInheritance } from "typeorm";
 import { ResponseDonation } from '../responses/ResponseDonation';
@@ -24,7 +23,6 @@ export abstract class Donation {
   /**
    * The donations's donor.
    */
-  @IsNotEmpty()
   @ManyToOne(() => Donor, donor => donor.donations)
   donor: Donor;