From 37afc10e44b4beed4563bd67bbba0fbbe42c1c75 Mon Sep 17 00:00:00 2001 From: Nicolai Ort Date: Sun, 20 Dec 2020 18:46:43 +0100 Subject: [PATCH] Fixed messages and comments for RunnerOrganisationErrors ref #39 --- src/errors/RunnerOrganisationErrors.ts | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/errors/RunnerOrganisationErrors.ts b/src/errors/RunnerOrganisationErrors.ts index 040befb..db524df 100644 --- a/src/errors/RunnerOrganisationErrors.ts +++ b/src/errors/RunnerOrganisationErrors.ts @@ -3,7 +3,6 @@ import { NotAcceptableError, NotFoundError } from 'routing-controllers'; /** * Error to throw when a runner organisation couldn't be found. - * Implemented this ways to work with the json-schema conversion for openapi. */ export class RunnerOrganisationNotFoundError extends NotFoundError { @IsString() @@ -15,39 +14,36 @@ export class RunnerOrganisationNotFoundError extends NotFoundError { /** * Error to throw when two runner organisations' ids don't match. - * Usually occurs when a user tries to change a runner's id. - * Implemented this way to work with the json-schema conversion for openapi. + * Usually occurs when a user tries to change a runner organisation's id. */ export class RunnerOrganisationIdsNotMatchingError extends NotAcceptableError { @IsString() name = "RunnerOrganisationIdsNotMatchingError" @IsString() - message = "The id's don't match!! \n And if you wanted to change a runner's id: This isn't allowed" + message = "The id's don't match!! \n And if you wanted to change a runner organisation's id: This isn't allowed!" } /** * Error to throw when a organisation still has runners associated. - * Implemented this waysto work with the json-schema conversion for openapi. */ export class RunnerOrganisationHasRunnersError extends NotAcceptableError { @IsString() name = "RunnerOrganisationHasRunnersError" @IsString() - message = "This organisation still has runners associated with it. \n If you want to delete this organisation with all it's runners and teams ass `?force` to your query." + message = "This organisation still has runners associated with it. \n If you want to delete this organisation with all it's runners and teams add `?force` to your query." } /** - * Error to throw when a organisation still has runners associated. - * Implemented this waysto work with the json-schema conversion for openapi. + * Error to throw when a organisation still has teams associated. */ export class RunnerOrganisationHasTeamsError extends NotAcceptableError { @IsString() name = "RunnerOrganisationHasTeamsError" @IsString() - message = "This organisation still has teams associated with it. \n If you want to delete this organisation with all it's runners and teams ass `?force` to your query." + message = "This organisation still has teams associated with it. \n If you want to delete this organisation with all it's runners and teams add `?force` to your query." } /**