Removed useless part from function and updated comments

ref #90

src/models/actions/create/CreateParticipant.ts

@@ -1,7 +1,7 @@
 import { IsEmail, IsInt, IsNotEmpty, IsOptional, IsPhoneNumber, IsString } from 'class-validator';
 import { getConnectionManager } from 'typeorm';
 import { config } from '../../../config';
-import { AddressNotFoundError, AddressWrongTypeError } from '../../../errors/AddressErrors';
+import { AddressNotFoundError } from '../../../errors/AddressErrors';
 import { Address } from '../../entities/Address';
 
 /**
@@ -47,26 +47,18 @@ export abstract class CreateParticipant {
     email?: string;
 
     /**
-     * The new participant's address.
-     * Must be of type number (address id).
+     * The new participant's address's id.
      */
     @IsInt()
     @IsOptional()
     address?: number;
 
     /**
-     * Gets the new participant's address by it's address.
+     * Gets the new participant's address by it's id.
      */
     public async getAddress(): Promise<Address> {
-        if (this.address === undefined || this.address === null) {
-            return null;
-        }
-        if (!isNaN(this.address)) {
-            let address = await getConnectionManager().get().getRepository(Address).findOne({ id: this.address });
-            if (!address) { throw new AddressNotFoundError; }
-            return address;
-        }
-
-        throw new AddressWrongTypeError;
+        let address = await getConnectionManager().get().getRepository(Address).findOne({ id: this.address });
+        if (!address) { throw new AddressNotFoundError; }
+        return address;
     }
 }