From 8d4c8a455398a77ebe6aa53f1e3cc06bc5af4b3a Mon Sep 17 00:00:00 2001 From: Nicolai Ort Date: Fri, 15 Jan 2021 18:13:10 +0100 Subject: [PATCH] Removed useless part from function ref #90 --- .../actions/create/CreateGroupContact.ts | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/src/models/actions/create/CreateGroupContact.ts b/src/models/actions/create/CreateGroupContact.ts index c6e10a8..463dbfb 100644 --- a/src/models/actions/create/CreateGroupContact.ts +++ b/src/models/actions/create/CreateGroupContact.ts @@ -1,7 +1,7 @@ import { IsEmail, IsInt, IsNotEmpty, IsOptional, IsPhoneNumber, IsString } from 'class-validator'; import { getConnectionManager } from 'typeorm'; import { config } from '../../../config'; -import { AddressNotFoundError, AddressWrongTypeError } from '../../../errors/AddressErrors'; +import { AddressNotFoundError } from '../../../errors/AddressErrors'; import { Address } from '../../entities/Address'; import { GroupContact } from '../../entities/GroupContact'; @@ -31,8 +31,7 @@ export class CreateGroupContact { lastname: string; /** - * The new contact's address. - * Must be the address's id. + * The new contact's address's id. */ @IsInt() @IsOptional() @@ -57,16 +56,9 @@ export class CreateGroupContact { * Gets the new contact's address by it's id. */ public async getAddress(): Promise
{ - if (this.address === undefined || this.address === null) { - return null; - } - if (!isNaN(this.address)) { - let address = await getConnectionManager().get().getRepository(Address).findOne({ id: this.address }); - if (!address) { throw new AddressNotFoundError; } - return address; - } - - throw new AddressWrongTypeError; + let address = await getConnectionManager().get().getRepository(Address).findOne({ id: this.address }); + if (!address) { throw new AddressNotFoundError; } + return address; } /**