Smoothed out the participant creation process regarting addresses

ref #13
This commit is contained in:
Nicolai Ort 2020-12-05 12:39:11 +01:00
parent 8870b26ce6
commit 975d30e411
2 changed files with 20 additions and 26 deletions

View File

@ -1,12 +1,12 @@
import { IsString } from 'class-validator'; import { IsString } from 'class-validator';
import { NotAcceptableError, NotFoundError } from 'routing-controllers'; import { NotAcceptableError, NotFoundError } from 'routing-controllers';
export class ParticipantOnlyOneAddressAllowedError extends NotAcceptableError { export class ParticipantAddressWrongTypeError extends NotAcceptableError {
@IsString() @IsString()
name = "ParticipantOnlyOneAddressAllowedError" name = "ParticipantAddressWrongTypeError"
@IsString() @IsString()
message = "Participant's can only have one address! \n You provided an id and address object.." message = "The participant's address must be either a existing address, new address or a existing adress's id. \n You provided a object of another type."
} }
export class ParticipantAddressNotFoundError extends NotFoundError { export class ParticipantAddressNotFoundError extends NotFoundError {

View File

@ -1,6 +1,6 @@
import { IsEmail, IsInt, IsNotEmpty, IsObject, IsOptional, IsPhoneNumber, IsString } from 'class-validator'; import { IsEmail, IsNotEmpty, IsObject, IsOptional, IsPhoneNumber, IsString } from 'class-validator';
import { getConnectionManager } from 'typeorm'; import { getConnectionManager } from 'typeorm';
import { ParticipantOnlyOneAddressAllowedError } from '../../errors/ParticipantErrors'; import { ParticipantAddressNotFoundError, ParticipantAddressWrongTypeError } from '../../errors/ParticipantErrors';
import { Address } from '../entities/Address'; import { Address } from '../entities/Address';
import { CreateAddress } from './CreateAddress'; import { CreateAddress } from './CreateAddress';
@ -45,39 +45,33 @@ export abstract class CreateParticipant {
@IsEmail() @IsEmail()
email?: string; email?: string;
/**
* The new participant's address's id.
* Optional - please provide either addressId or address.
*/
@IsInt()
@IsOptional()
addressId?: number;
/** /**
* The new participant's address. * The new participant's address.
* Optional - please provide either addressId or address. * Must be of type number (address id), createAddress (new address) or address (existing address)
* Optional.
*/ */
@IsObject() @IsObject()
@IsOptional() address?: number | CreateAddress | Address;
address?: CreateAddress;
/** /**
* Creates a Participant entity from this. * Creates a Participant entity from this.
*/ */
public async getAddress(): Promise<Address> { public async getAddress(): Promise<Address> {
let address: Address; if (this.address === undefined) {
if (this.addressId !== undefined && this.address !== undefined) {
throw new ParticipantOnlyOneAddressAllowedError
}
if (this.addressId === undefined && this.address === undefined) {
return null; return null;
} }
if (this.address! instanceof Address) {
if (this.addressId) { return this.address;
return await getConnectionManager().get().getRepository(Address).findOne({ id: this.addressId }); }
if (this.address! instanceof CreateAddress) {
return this.address.toAddress();
}
if (!isNaN(this.address)) {
let address = await getConnectionManager().get().getRepository(Address).findOne({ id: this.address });
if (!address) { throw new ParticipantAddressNotFoundError; }
return address;
} }
return this.address.toAddress(); throw new ParticipantAddressWrongTypeError;
} }
} }