From 97c01ce81a48170be014084df8028091c43f03f4 Mon Sep 17 00:00:00 2001 From: Nicolai Ort Date: Fri, 15 Jan 2021 18:30:20 +0100 Subject: [PATCH] Refactoring: switched update org address from objects to ids ref #90 --- .../actions/update/UpdateRunnerOrganisation.ts | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/models/actions/update/UpdateRunnerOrganisation.ts b/src/models/actions/update/UpdateRunnerOrganisation.ts index 7270923..795e20c 100644 --- a/src/models/actions/update/UpdateRunnerOrganisation.ts +++ b/src/models/actions/update/UpdateRunnerOrganisation.ts @@ -18,21 +18,17 @@ export class UpdateRunnerOrganisation extends CreateRunnerGroup { id: number; /** - * The updated organisation's address. - * Just has to contain the address's id - everything else won't be checked or changed. - * Optional. + * The updated organisation's address's id. */ @IsInt() @IsOptional() - address?: Address; + address?: number; /** * Loads the organisation's address based on it's id. */ public async getAddress(): Promise
{ - if (this.address === undefined || this.address === null) { - return null; - } + if (!this.address) { return null; } let address = await getConnectionManager().get().getRepository(Address).findOne({ id: this.address.id }); if (!address) { throw new AddressNotFoundError; } return address; @@ -45,7 +41,7 @@ export class UpdateRunnerOrganisation extends CreateRunnerGroup { organisation.name = this.name; organisation.contact = await this.getContact(); - // organisation.address = await this.getAddress(); + organisation.address = await this.getAddress(); return organisation; }