Deletes now return 204 instead of 404 (better rest compatability)

ref #13

src/controllers/RunnerController.ts

@@ -6,6 +6,7 @@ import { RunnerGroupNeededError, RunnerIdsNotMatchingError, RunnerNotFoundError
 import { RunnerGroupNotFoundError } from '../errors/RunnerGroupErrors';
 import { CreateRunner } from '../models/actions/CreateRunner';
 import { Runner } from '../models/entities/Runner';
+import { ResponseEmpty } from '../models/responses/ResponseEmpty';
 import { ResponseRunner } from '../models/responses/ResponseRunner';
 
 @JsonController('/runners')
@@ -83,10 +84,11 @@ export class RunnerController {
 
 	@Delete('/:id')
 	@ResponseSchema(ResponseRunner)
-	@ResponseSchema(RunnerNotFoundError, { statusCode: 404 })
+	@ResponseSchema(ResponseEmpty, { statusCode: 204 })
+	@OnUndefined(204)
 	@OpenAPI({ description: 'Delete a specified runner (if it exists).' })
 	async remove(@EntityFromParam('id') runner: Runner, @QueryParam("force") force: boolean) {
-		if (!runner) { throw new RunnerNotFoundError(); }
+		if (!runner) { return null; }
 		const responseRunner = await this.runnerRepository.findOne(runner, { relations: ['scans', 'group'] });
 
 		if (!runner) {