Deletes now return 204 instead of 404 (better rest compatability)

ref #13
This commit is contained in:
2020-12-09 19:34:49 +01:00
parent 3ae124ef68
commit a068c4d318
7 changed files with 30 additions and 12 deletions

View File

@@ -6,6 +6,7 @@ import { UserIdsNotMatchingError, UserNotFoundError } from '../errors/UserErrors
import { UserGroupNotFoundError } from '../errors/UserGroupErrors';
import { CreateUser } from '../models/actions/CreateUser';
import { User } from '../models/entities/User';
import { ResponseEmpty } from '../models/responses/ResponseEmpty';
@JsonController('/users')
@@ -72,11 +73,12 @@ export class UserController {
@Delete('/:id')
@ResponseSchema(User)
@ResponseSchema(UserNotFoundError, { statusCode: 404 })
@ResponseSchema(ResponseEmpty, { statusCode: 204 })
@OnUndefined(204)
@OpenAPI({ description: 'Delete a specified runner (if it exists).' })
async remove(@EntityFromParam('id') user: User) {
if (!user) {
throw new UserNotFoundError();
return null;
}
await this.userRepository.delete(user);