From aaec09d2ab08a76e9d367fdfefc01cea5588f1b9 Mon Sep 17 00:00:00 2001 From: Nicolai Ort Date: Fri, 26 Feb 2021 17:32:26 +0100 Subject: [PATCH] Fixed wrong body acceptance type ref #146 --- src/controllers/UserGroupController.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/controllers/UserGroupController.ts b/src/controllers/UserGroupController.ts index fd33f67..71d0b3a 100644 --- a/src/controllers/UserGroupController.ts +++ b/src/controllers/UserGroupController.ts @@ -1,7 +1,6 @@ import { Authorized, Body, Delete, Get, JsonController, OnUndefined, Param, Post, Put, QueryParam } from 'routing-controllers'; import { OpenAPI, ResponseSchema } from 'routing-controllers-openapi'; import { getConnectionManager, Repository } from 'typeorm'; -import { EntityFromBody } from 'typeorm-routing-controllers-extensions'; import { UserGroupIdsNotMatchingError, UserGroupNotFoundError } from '../errors/UserGroupErrors'; import { CreateUserGroup } from '../models/actions/create/CreateUserGroup'; import { UpdateUserGroup } from '../models/actions/update/UpdateUserGroup'; @@ -82,7 +81,7 @@ export class UserGroupController { @ResponseSchema(UserGroupNotFoundError, { statusCode: 404 }) @ResponseSchema(UserGroupIdsNotMatchingError, { statusCode: 406 }) @OpenAPI({ description: "Update the group whose id you provided.
To change the permissions granted to the group please use /api/permissions instead.
Please remember that ids can't be changed." }) - async put(@Param('id') id: number, @EntityFromBody() updateGroup: UpdateUserGroup) { + async put(@Param('id') id: number, @Body({ validate: true }) updateGroup: UpdateUserGroup) { let oldGroup = await this.userGroupsRepository.findOne({ id: id }); if (!oldGroup) { @@ -94,7 +93,7 @@ export class UserGroupController { } await this.userGroupsRepository.save(await updateGroup.update(oldGroup)); - return (await this.userGroupsRepository.findOne({ id: id }, { relations: ['permissions', 'groups'] })).toResponse(); + return (await this.userGroupsRepository.findOne({ id: id }, { relations: ['permissions'] })).toResponse(); } @Delete('/:id')