Merge branch 'dev' into feature/17-automated_tests

# Conflicts:
#	src/controllers/RunnerController.ts
#	src/models/actions/CreateParticipant.ts
This commit is contained in:
2020-12-10 19:37:52 +01:00
7 changed files with 71 additions and 15 deletions

View File

@@ -47,7 +47,7 @@ export abstract class CreateParticipant {
/**
* The new participant's address.
* Must be of type number (address id), createAddress (new address) or address (existing address)
* Must be of type number (address id).
* Optional.
*/
@IsInt()

View File

@@ -10,8 +10,7 @@ import { CreateParticipant } from './CreateParticipant';
export class CreateRunner extends CreateParticipant {
/**
* The new runner's team's id.
* Either provide this or his organisation's id.
* The new runner's group's id.
*/
@IsInt()
group: number;

View File

@@ -20,16 +20,16 @@ export abstract class CreateRunnerGroup {
contact?: number;
/**
* Deals with the contact for groups this.
* Get's this group's contact from this.address.
*/
public async getContact(): Promise<GroupContact> {
if (this.contact === undefined) {
return null;
}
if (!isNaN(this.contact)) {
let address = await getConnectionManager().get().getRepository(GroupContact).findOne({ id: this.contact });
if (!address) { throw new GroupContactNotFoundError; }
return address;
let contact = await getConnectionManager().get().getRepository(GroupContact).findOne({ id: this.contact });
if (!contact) { throw new GroupContactNotFoundError; }
return contact;
}
throw new GroupContactWrongTypeError;

View File

@@ -8,7 +8,7 @@ import { CreateRunnerGroup } from './CreateRunnerGroup';
export class CreateRunnerOrganisation extends CreateRunnerGroup {
/**
* The new organisation's address.
* Must be of type number (address id), createAddress (new address) or address (existing address)
* Must be of type number (address id).
* Optional.
*/
@IsInt()
@@ -16,7 +16,7 @@ export class CreateRunnerOrganisation extends CreateRunnerGroup {
address?: number;
/**
* Creates a Participant entity from this.
* Get's this org's address from this.address.
*/
public async getAddress(): Promise<Address> {
if (this.address === undefined) {

View File

@@ -10,7 +10,7 @@ export class CreateTrack {
name: string;
/**
* The track's distance in meters (must be greater 0).
* The track's distance in meters (must be greater than 0).
*/
@IsInt()
@IsPositive()

View File

@@ -0,0 +1,57 @@
import { IsInt, IsObject } from 'class-validator';
import { getConnectionManager } from 'typeorm';
import { RunnerGroupNotFoundError } from '../../errors/RunnerGroupErrors';
import { RunnerOrganisationWrongTypeError } from '../../errors/RunnerOrganisationErrors';
import { RunnerTeamNeedsParentError } from '../../errors/RunnerTeamErrors';
import { Runner } from '../entities/Runner';
import { RunnerGroup } from '../entities/RunnerGroup';
import { CreateParticipant } from './CreateParticipant';
export class UpdateRunner extends CreateParticipant {
/**
* The updated runner's id.
*/
@IsInt()
id: number;
/**
* The updated runner's new team/org.
*/
@IsObject()
group: RunnerGroup;
/**
* Creates a Runner entity from this.
*/
public async toRunner(): Promise<Runner> {
let newRunner: Runner = new Runner();
newRunner.id = this.id;
newRunner.firstname = this.firstname;
newRunner.middlename = this.middlename;
newRunner.lastname = this.lastname;
newRunner.phone = this.phone;
newRunner.email = this.email;
newRunner.group = await this.getGroup();
newRunner.address = await this.getAddress();
return newRunner;
}
/**
* Manages all the different ways a group can be provided.
*/
public async getGroup(): Promise<RunnerGroup> {
if (this.group === undefined) {
throw new RunnerTeamNeedsParentError();
}
if (!isNaN(this.group.id)) {
let group = await getConnectionManager().get().getRepository(RunnerGroup).findOne({ id: this.group.id });
if (!group) { throw new RunnerGroupNotFoundError; }
return group;
}
throw new RunnerOrganisationWrongTypeError;
}
}