From edac1a224c8ce6fa44ff39302431e64f014b7137 Mon Sep 17 00:00:00 2001
From: Nicolai Ort <info@nicolai-ort.com>
Date: Thu, 7 Jan 2021 16:59:57 +0100
Subject: [PATCH] Fixed runner scan validation bug

ref #67
---
 src/controllers/ScanController.ts      | 1 -
 src/models/entities/Runner.ts          | 2 +-
 src/models/responses/ResponseRunner.ts | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/controllers/ScanController.ts b/src/controllers/ScanController.ts
index d82195e..272a9ee 100644
--- a/src/controllers/ScanController.ts
+++ b/src/controllers/ScanController.ts
@@ -53,7 +53,6 @@ export class ScanController {
 	async post(@Body({ validate: true }) createScan: CreateScan) {
 		let scan = await createScan.toScan();
 		scan = await this.scanRepository.save(scan);
-		console.log(scan);
 		return (await this.scanRepository.findOne({ id: scan.id }, { relations: ['runner'] })).toResponse();
 	}
 
diff --git a/src/models/entities/Runner.ts b/src/models/entities/Runner.ts
index f391103..bc6bc5a 100644
--- a/src/models/entities/Runner.ts
+++ b/src/models/entities/Runner.ts
@@ -48,7 +48,7 @@ export class Runner extends Participant {
    * This is implemented here to avoid duplicate code in other files.
    */
   public get validScans(): Scan[] {
-    return this.scans.filter(scan => { scan.valid === true });
+    return this.scans.filter(scan => scan.valid == true);
   }
 
   /**
diff --git a/src/models/responses/ResponseRunner.ts b/src/models/responses/ResponseRunner.ts
index 82402a8..0d2fb67 100644
--- a/src/models/responses/ResponseRunner.ts
+++ b/src/models/responses/ResponseRunner.ts
@@ -30,7 +30,7 @@ export class ResponseRunner extends ResponseParticipant {
     public constructor(runner: Runner) {
         super(runner);
         if (!runner.scans) { this.distance = 0 }
-        else { this.distance = runner.scans.filter(scan => { scan.valid === true }).reduce((sum, current) => sum + current.distance, 0); }
+        else { this.distance = runner.validScans.reduce((sum, current) => sum + current.distance, 0); }
         this.group = runner.group;
     }
 }