User deletion now also delete's the users permissons

ref #6
This commit is contained in:
2020-12-18 15:49:42 +01:00
parent d4293c164d
commit ff3a5b4545
2 changed files with 10 additions and 9 deletions

View File

@@ -8,6 +8,7 @@ import { CreateUser } from '../models/actions/CreateUser';
import { User } from '../models/entities/User';
import { ResponseEmpty } from '../models/responses/ResponseEmpty';
import { ResponseUser } from '../models/responses/ResponseUser';
import { PermissionController } from './PermissionController';
@JsonController('/users')
@@ -86,15 +87,16 @@ export class UserController {
@OnUndefined(204)
@OpenAPI({ description: 'Delete a specified runner (if it exists).' })
async remove(@Param("id") id: number, @QueryParam("force") force: boolean) {
let runner = await this.userRepository.findOne({ id: id });
if (!runner) { return null; }
const responseUser = await this.userRepository.findOne(runner, { relations: ['permissions', 'groups'] });
let user = await this.userRepository.findOne({ id: id });
if (!user) { return null; }
const responseUser = await this.userRepository.findOne({ id: id }, { relations: ['permissions', 'groups'] });;
if (!runner) {
throw new UserNotFoundError();
const permissionControler = new PermissionController();
for (let permission of responseUser.permissions) {
await permissionControler.remove(permission.id, true);
}
await this.userRepository.delete(runner);
await this.userRepository.delete(user);
return new ResponseUser(responseUser);
}
}