CHANGELOG.md

@@ -2,16 +2,9 @@
 
 All notable changes to this project will be documented in this file. Dates are displayed in UTC.
 
-#### [1.3.5](https://git.odit.services/lfk/backend/compare/1.3.4...1.3.5)
-
-- feat(runners): Generate selfservice urls on runner if requested or create/update/get single [`5415cd3`](https://git.odit.services/lfk/backend/commit/5415cd38a727e76632a01a4d2634a1777df5542c)
-
 #### [1.3.4](https://git.odit.services/lfk/backend/compare/1.3.3...1.3.4)
 
-> 28 March 2025
-
 - feat: add runnersViaSelfservice to statsControllerGet [`5c5000a`](https://git.odit.services/lfk/backend/commit/5c5000a218b47815e6846ac8b857dcd1995bfa6f)
-- chore(release): 1.3.4 [`175ba52`](https://git.odit.services/lfk/backend/commit/175ba52ffae8e6ba1fdc1603ac2f5eba15602046)
 
 #### [1.3.3](https://git.odit.services/lfk/backend/compare/v1.3.2...1.3.3)
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@odit/lfk-backend",
-  "version": "1.3.5",
+  "version": "1.3.4",
   "main": "src/app.ts",
   "repository": "https://git.odit.services/lfk/backend",
   "author": {

src/controllers/RunnerController.ts

@@ -30,7 +30,7 @@ export class RunnerController {
 	@Authorized("RUNNER:GET")
 	@ResponseSchema(ResponseRunner, { isArray: true })
 	@OpenAPI({ description: 'Lists all runners from all teams/orgs. <br> This includes the runner\'s group and distance ran.' })
-	async getAll(@QueryParam("page", { required: false }) page: number, @QueryParam("page_size", { required: false }) page_size: number = 100, @QueryParam("selfservice_links", { required: false }) selfservice_links: boolean = false) {
+	async getAll(@QueryParam("page", { required: false }) page: number, @QueryParam("page_size", { required: false }) page_size: number = 100) {
 		let responseRunners: ResponseRunner[] = new Array<ResponseRunner>();
 		let runners: Array<Runner>;
 
@@ -41,7 +41,7 @@ export class RunnerController {
 		}
 
 		runners.forEach(runner => {
-			responseRunners.push(new ResponseRunner(runner, selfservice_links));
+			responseRunners.push(new ResponseRunner(runner));
 		});
 		return responseRunners;
 	}
@@ -55,7 +55,7 @@ export class RunnerController {
 	async getOne(@Param('id') id: number) {
 		let runner = await this.runnerRepository.findOne({ id: id }, { relations: ['scans', 'group', 'group.parentGroup', 'scans.track', 'cards'] })
 		if (!runner) { throw new RunnerNotFoundError(); }
-		return new ResponseRunner(runner, true);
+		return new ResponseRunner(runner);
 	}
 
 	@Get('/:id/scans')
@@ -98,7 +98,7 @@ export class RunnerController {
 		}
 
 		runner = await this.runnerRepository.save(runner)
-		return new ResponseRunner(await this.runnerRepository.findOne(runner, { relations: ['scans', 'group', 'group.parentGroup', 'scans.track', 'cards'] }), true);
+		return new ResponseRunner(await this.runnerRepository.findOne(runner, { relations: ['scans', 'group', 'group.parentGroup', 'scans.track', 'cards'] }));
 	}
 
 	@Put('/:id')
@@ -119,7 +119,7 @@ export class RunnerController {
 		}
 
 		await this.runnerRepository.save(await runner.update(oldRunner));
-		return new ResponseRunner(await this.runnerRepository.findOne({ id: id }, { relations: ['scans', 'group', 'group.parentGroup', 'scans.track', 'cards'] }), true);
+		return new ResponseRunner(await this.runnerRepository.findOne({ id: id }, { relations: ['scans', 'group', 'group.parentGroup', 'scans.track', 'cards'] }));
 	}
 
 	@Delete('/:id')

src/models/responses/ResponseRunner.ts

@@ -1,10 +1,7 @@
 import {
     IsInt,
-    IsObject,
+    IsObject
-    IsOptional,
-    IsString
 } from "class-validator";
-import { JwtCreator } from '../../jwtcreator';
 import { Runner } from '../entities/Runner';
 import { ResponseObjectType } from '../enums/ResponseObjectType';
 import { IResponse } from './IResponse';
@@ -33,26 +30,14 @@ export class ResponseRunner extends ResponseParticipant implements IResponse {
     @IsObject()
     group: ResponseRunnerGroup;
 
-    /**
-     * A selfservice link for our new runner.
-     */
-    @IsOptional()
-    @IsString()
-    selfserviceLink: string;
-
     /**
      * Creates a ResponseRunner object from a runner.
      * @param runner The user the response shall be build for.
      */
-    public constructor(runner: Runner, generateSelfServiceLink: boolean = false) {
+    public constructor(runner: Runner) {
         super(runner);
         if (!runner.scans) { this.distance = 0 }
         else { this.distance = runner.validScans.reduce((sum, current) => sum + current.distance, 0); }
         if (runner.group) { this.group = runner.group.toResponse(); }
-
-        if (generateSelfServiceLink) {
-            const token = JwtCreator.createSelfService(runner);
-            this.selfserviceLink = `${process.env.SELFSERVICE_URL}/profile/${token}`;
-        }
     }
 }