From a2cd54fba4a987f7f7dbab22cc958f9aea2817ff Mon Sep 17 00:00:00 2001
From: Philipp Dormann <philipp@philippdormann.de>
Date: Fri, 28 Mar 2025 11:16:44 +0100
Subject: [PATCH] feat: improve ConfirmTeamDeletionModal

---
 .../teams/ConfirmTeamDeletion.svelte          | 103 ------------------
 .../teams/ConfirmTeamDeletionModal.svelte     | 103 ++++++++++++++++++
 src/components/teams/TeamDetail.svelte        |   8 +-
 src/components/teams/Teams.svelte             |  70 +++---------
 4 files changed, 124 insertions(+), 160 deletions(-)
 delete mode 100644 src/components/teams/ConfirmTeamDeletion.svelte
 create mode 100644 src/components/teams/ConfirmTeamDeletionModal.svelte

diff --git a/src/components/teams/ConfirmTeamDeletion.svelte b/src/components/teams/ConfirmTeamDeletion.svelte
deleted file mode 100644
index d9d64b4e..00000000
--- a/src/components/teams/ConfirmTeamDeletion.svelte
+++ /dev/null
@@ -1,103 +0,0 @@
-<script>
-  import { _ } from "svelte-i18n";
-  import { clickOutside } from "../base/outsideclick";
-
-  import { RunnerTeamService } from "@odit/lfk-client-js";
-  import { createEventDispatcher } from "svelte";
-  import toast from "svelte-french-toast";
-  export let modal_open;
-  export let delete_team;
-  const dispatch = createEventDispatcher();
-  function cancelDelete() {
-    modal_open = false;
-    dispatch("cancelDelete", { id: delete_team.id });
-  }
-  function deleteTeam() {
-    toast.loading($_("deleting-team"));
-    RunnerTeamService.runnerTeamControllerRemove(delete_team.id, true)
-      .then((resp) => {
-        toast.dismiss();
-        toast($_("team-deleted"));
-        location.replace("./");
-      })
-      .catch((err) => {});
-  }
-</script>
-
-{#if modal_open}
-  <div
-    class="fixed z-10 inset-0 overflow-y-auto"
-    use:clickOutside
-    on:click_outside={cancelDelete}
-  >
-    <div
-      class="flex items-end justify-center min-h-screen pt-4 px-4 pb-20 text-center sm:block sm:p-0"
-    >
-      <div class="fixed inset-0 transition-opacity" aria-hidden="true">
-        <div
-          class="absolute inset-0 bg-gray-500 opacity-75"
-          data-id="modal_backdrop"
-        />
-      </div>
-      <span
-        class="hidden sm:inline-block sm:align-middle sm:h-screen"
-        aria-hidden="true">&#8203;</span
-      >
-      <div
-        class="inline-block align-bottom bg-white rounded-lg text-left overflow-hidden shadow-xl transform transition-all sm:my-8 sm:align-middle sm:max-w-lg sm:w-full"
-        role="dialog"
-        aria-modal="true"
-        aria-labelledby="modal-headline"
-      >
-        <div class="bg-white px-4 pt-5 pb-4 sm:p-6 sm:pb-4">
-          <div class="sm:flex sm:items-start">
-            <div
-              class="mx-auto flex-shrink-0 flex items-center justify-center h-12 w-12 rounded-full bg-blue-100 sm:mx-0 sm:h-10 sm:w-10"
-            >
-              <svg
-                class="h-6 w-6 text-blue-600"
-                fill="currentColor"
-                width="24"
-                height="24"
-                xmlns="http://www.w3.org/2000/svg"
-                viewBox="0 0 640 512"
-                ><path
-                  fill="currentColor"
-                  d="M96 224c35.3 0 64-28.7 64-64s-28.7-64-64-64-64 28.7-64 64 28.7 64 64 64zm448 0c35.3 0 64-28.7 64-64s-28.7-64-64-64-64 28.7-64 64 28.7 64 64 64zm32 32h-64c-17.6 0-33.5 7.1-45.1 18.6 40.3 22.1 68.9 62 75.1 109.4h66c17.7 0 32-14.3 32-32v-32c0-35.3-28.7-64-64-64zm-256 0c61.9 0 112-50.1 112-112S381.9 32 320 32 208 82.1 208 144s50.1 112 112 112zm76.8 32h-8.3c-20.8 10-43.9 16-68.5 16s-47.6-6-68.5-16h-8.3C179.6 288 128 339.6 128 403.2V432c0 26.5 21.5 48 48 48h288c26.5 0 48-21.5 48-48v-28.8c0-63.6-51.6-115.2-115.2-115.2zm-223.7-13.4C161.5 263.1 145.6 256 128 256H64c-35.3 0-64 28.7-64 64v32c0 17.7 14.3 32 32 32h65.9c6.3-47.4 34.9-87.3 75.2-109.4z"
-                /></svg
-              >
-            </div>
-            <div class="mt-3 text-center sm:mt-0 sm:ml-4 sm:text-left">
-              <h3 class="text-lg leading-6 font-medium text-gray-900">
-                {$_("attention")}
-              </h3>
-              <div class="mt-2 mb-6">
-                <p class="text-sm text-gray-500">
-                  {$_("do-you-want-to-delete-the-team-delete_team-name", {
-                    values: { teamname: delete_team.name },
-                  })}<br />{$_("all-associated-runners-will-be-deleted-too")}
-                </p>
-              </div>
-            </div>
-          </div>
-        </div>
-        <div class="bg-gray-50 px-4 py-3 sm:px-6 sm:flex sm:flex-row-reverse">
-          <button
-            on:click={deleteTeam}
-            type="button"
-            class="w-full inline-flex justify-center rounded-md border border-transparent shadow-sm px-4 py-2 bg-red-600 text-base font-medium text-white hover:bg-red-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-red-500 sm:ml-3 sm:w-auto sm:text-sm"
-          >
-            {$_("confirm-delete-team-and-associated-runners")}
-          </button>
-          <button
-            on:click={cancelDelete}
-            type="button"
-            class="mt-3 w-full inline-flex justify-center rounded-md border border-gray-300 shadow-sm px-4 py-2 bg-white text-base font-medium text-gray-700 hover:bg-gray-50 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-indigo-500 sm:mt-0 sm:ml-3 sm:w-auto sm:text-sm"
-          >
-            {$_("cancel-keep-team")}
-          </button>
-        </div>
-      </div>
-    </div>
-  </div>
-{/if}
diff --git a/src/components/teams/ConfirmTeamDeletionModal.svelte b/src/components/teams/ConfirmTeamDeletionModal.svelte
new file mode 100644
index 00000000..a22f0dd2
--- /dev/null
+++ b/src/components/teams/ConfirmTeamDeletionModal.svelte
@@ -0,0 +1,103 @@
+<script>
+	import { _ } from "svelte-i18n";
+	import { clickOutside } from "../base/outsideclick";
+
+	import { RunnerTeamService } from "@odit/lfk-client-js";
+	import { createEventDispatcher } from "svelte";
+	import toast from "svelte-french-toast";
+	export let modal_open;
+	export let delete_team;
+	const dispatch = createEventDispatcher();
+	function cancelDelete() {
+		modal_open = false;
+		dispatch("cancelDelete", { id: delete_team.id });
+	}
+	function deleteTeam() {
+		toast.loading($_("deleting-team"));
+		RunnerTeamService.runnerTeamControllerRemove(delete_team.id, true)
+			.then((resp) => {
+				toast.dismiss();
+				toast($_("team-deleted"));
+				location.replace("./");
+			})
+			.catch((err) => {});
+	}
+</script>
+
+{#if modal_open}
+	<div
+		class="fixed z-10 inset-0 overflow-y-auto"
+		use:clickOutside
+		on:click_outside={cancelDelete}
+	>
+		<div
+			class="flex items-end justify-center min-h-screen pt-4 px-4 pb-20 text-center sm:block sm:p-0"
+		>
+			<div class="fixed inset-0 transition-opacity" aria-hidden="true">
+				<div
+					class="absolute inset-0 bg-gray-500 opacity-75"
+					data-id="modal_backdrop"
+				/>
+			</div>
+			<span
+				class="hidden sm:inline-block sm:align-middle sm:h-screen"
+				aria-hidden="true">&#8203;</span
+			>
+			<div
+				class="inline-block align-bottom bg-white rounded-lg text-left overflow-hidden shadow-xl transform transition-all sm:my-8 sm:align-middle sm:max-w-lg sm:w-full"
+				role="dialog"
+				aria-modal="true"
+				aria-labelledby="modal-headline"
+			>
+				<div class="bg-white px-4 pt-5 pb-4 sm:p-6 sm:pb-4">
+					<div class="sm:flex sm:items-start">
+						<div
+							class="mx-auto flex-shrink-0 flex items-center justify-center h-12 w-12 rounded-full bg-blue-100 sm:mx-0 sm:h-10 sm:w-10"
+						>
+							<svg
+								class="h-6 w-6 text-blue-600"
+								fill="currentColor"
+								width="24"
+								height="24"
+								xmlns="http://www.w3.org/2000/svg"
+								viewBox="0 0 640 512"
+								><path
+									fill="currentColor"
+									d="M96 224c35.3 0 64-28.7 64-64s-28.7-64-64-64-64 28.7-64 64 28.7 64 64 64zm448 0c35.3 0 64-28.7 64-64s-28.7-64-64-64-64 28.7-64 64 28.7 64 64 64zm32 32h-64c-17.6 0-33.5 7.1-45.1 18.6 40.3 22.1 68.9 62 75.1 109.4h66c17.7 0 32-14.3 32-32v-32c0-35.3-28.7-64-64-64zm-256 0c61.9 0 112-50.1 112-112S381.9 32 320 32 208 82.1 208 144s50.1 112 112 112zm76.8 32h-8.3c-20.8 10-43.9 16-68.5 16s-47.6-6-68.5-16h-8.3C179.6 288 128 339.6 128 403.2V432c0 26.5 21.5 48 48 48h288c26.5 0 48-21.5 48-48v-28.8c0-63.6-51.6-115.2-115.2-115.2zm-223.7-13.4C161.5 263.1 145.6 256 128 256H64c-35.3 0-64 28.7-64 64v32c0 17.7 14.3 32 32 32h65.9c6.3-47.4 34.9-87.3 75.2-109.4z"
+								/></svg
+							>
+						</div>
+						<div class="mt-3 text-center sm:mt-0 sm:ml-4 sm:text-left">
+							<h3 class="text-lg leading-6 font-medium text-gray-900">
+								{$_("do-you-want-to-delete-the-team-delete_team-name", {
+									values: { teamname: delete_team.name },
+								})}
+							</h3>
+							<div class="mt-2 mb-6">
+								<p class="text-sm text-gray-500">
+									{$_("all-associated-runners-will-be-deleted-too")}
+								</p>
+							</div>
+						</div>
+					</div>
+				</div>
+				<div class="bg-gray-50 px-4 py-3 sm:px-6 sm:flex sm:flex-row-reverse">
+					<button
+						on:click={deleteTeam}
+						type="button"
+						class="w-full inline-flex justify-center rounded-md border border-transparent shadow-sm px-4 py-2 bg-red-600 text-base font-medium text-white hover:bg-red-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-red-500 sm:ml-3 sm:w-auto sm:text-sm"
+					>
+						{$_("confirm-delete-team-and-associated-runners")}
+					</button>
+					<button
+						on:click={cancelDelete}
+						type="button"
+						class="mt-3 w-full inline-flex justify-center rounded-md border border-gray-300 shadow-sm px-4 py-2 bg-white text-base font-medium text-gray-700 hover:bg-gray-50 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-indigo-500 sm:mt-0 sm:ml-3 sm:w-auto sm:text-sm"
+					>
+						{$_("cancel-keep-team")}
+					</button>
+				</div>
+			</div>
+		</div>
+	</div>
+{/if}
diff --git a/src/components/teams/TeamDetail.svelte b/src/components/teams/TeamDetail.svelte
index 90201041..0de640e7 100644
--- a/src/components/teams/TeamDetail.svelte
+++ b/src/components/teams/TeamDetail.svelte
@@ -4,15 +4,13 @@
 		RunnerOrganizationService,
 		RunnerTeamService,
 	} from "@odit/lfk-client-js";
-	import { getLocaleFromNavigator, _ } from "svelte-i18n";
+	import { _ } from "svelte-i18n";
 	import toast from "svelte-french-toast";
-
 	import store from "../../store";
 	import Select from "svelte-select";
 	import ImportRunnerModal from "../runners/ImportRunnerModal.svelte";
 	import PromiseError from "../base/PromiseError.svelte";
-	import ConfirmTeamDeletion from "./ConfirmTeamDeletion.svelte";
-	import Teams from "./Teams.svelte";
+	import ConfirmTeamDeletionModal from "./ConfirmTeamDeletionModal.svelte";
 	import GenerateSponsoringContracts from "../pdf_generation/GenerateSponsoringContracts.svelte";
 	import GenerateRunnerCards from "../pdf_generation/GenerateRunnerCards.svelte";
 	import GenerateRunnerCertificates from "../pdf_generation/GenerateRunnerCertificates.svelte";
@@ -105,7 +103,7 @@
 	opened_from="TeamDetail"
 	bind:import_modal_open
 />
-<ConfirmTeamDeletion bind:modal_open bind:delete_team />
+<ConfirmTeamDeletionModal bind:modal_open bind:delete_team />
 {#if data_loaded}
 	<section class="container p-5">
 		<div class="flex flex-row mb-4">
diff --git a/src/components/teams/Teams.svelte b/src/components/teams/Teams.svelte
index 81d0a508..af9e08a5 100644
--- a/src/components/teams/Teams.svelte
+++ b/src/components/teams/Teams.svelte
@@ -6,11 +6,10 @@
 	const teams_promise = RunnerTeamService.runnerTeamControllerGetAll();
 	import store, { users as usersstore } from "../../store.js";
 	import TeamsEmptyState from "./TeamsEmptyState.svelte";
-	import ConfirmTeamDeletion from "./ConfirmTeamDeletion.svelte";
+	import ConfirmTeamDeletionModal from "./ConfirmTeamDeletionModal.svelte";
 	import GenerateSponsoringContracts from "../pdf_generation/GenerateSponsoringContracts.svelte";
 	import GenerateRunnerCards from "../pdf_generation/GenerateRunnerCards.svelte";
 	import GenerateRunnerCertificates from "../pdf_generation/GenerateRunnerCertificates.svelte";
-	import toast from "svelte-french-toast";
 	$: searchvalue = "";
 	$: active_deletes = [];
 	$: sponsoring_contracts_show = current_teams.some(
@@ -19,6 +18,7 @@
 	$: cards_show = current_teams.some((r) => r.is_selected === true);
 	$: certificates_show = current_teams.some((r) => r.is_selected === true);
 	$: generate_teams = current_teams.filter((r) => r.is_selected === true);
+	let delete_modal_open = false;
 	let modal_open = false;
 	let delete_team = {};
 	usersstore.subscribe((val) => {
@@ -44,12 +44,12 @@
 			{$_("create-team")}
 		</button>
 	{/if}
-	<ConfirmTeamDeletion
+	<ConfirmTeamDeletionModal
 		on:cancelDelete={(event) => {
 			modal_open = false;
 			active_deletes[event.detail.id] = false;
 		}}
-		bind:modal_open
+		bind:modal_open={delete_modal_open}
 		bind:delete_team
 	/>
 	{#if store.state.jwtinfo.userdetails.permissions.includes("TEAM:GET")}
@@ -182,61 +182,27 @@
 												</div>
 											</div>
 										</td>
-										{#if active_deletes[t.id] === true}
-											<td
-												class="px-6 py-4 whitespace-nowrap text-right text-sm font-medium"
+										<td
+											class="px-6 py-4 whitespace-nowrap text-right text-sm font-medium"
+										>
+											<a
+												href="./{t.id}"
+												class="text-indigo-600 hover:text-indigo-900"
+												>{$_("details")}</a
 											>
+											{#if store.state.jwtinfo.userdetails.permissions.includes("TEAM:DELETE")}
 												<button
 													on:click={() => {
-														active_deletes[t.id] = false;
-													}}
-													tabindex="0"
-													class="ml-4 text-indigo-600 hover:text-indigo-900 cursor-pointer"
-													>{$_("cancel-delete")}</button
-												>
-												<button
-													on:click={() => {
-														RunnerTeamService.runnerTeamControllerRemove(
-															t.id,
-															false
-														)
-															.then((resp) => {
-																current_teams = current_teams.filter(
-																	(obj) => obj.id !== t.id
-																);
-																toast($_("team-deleted"));
-															})
-															.catch((err) => {
-																modal_open = true;
-																delete_team = t;
-															});
+														active_deletes[t.id] = true;
+														delete_modal_open = true;
+														delete_team = t;
 													}}
 													tabindex="0"
 													class="ml-4 text-red-600 hover:text-red-900 cursor-pointer"
-													>{$_("confirm-delete")}</button
+													>{$_("delete")}</button
 												>
-											</td>
-										{:else}
-											<td
-												class="px-6 py-4 whitespace-nowrap text-right text-sm font-medium"
-											>
-												<a
-													href="./{t.id}"
-													class="text-indigo-600 hover:text-indigo-900"
-													>{$_("details")}</a
-												>
-												{#if store.state.jwtinfo.userdetails.permissions.includes("TEAM:DELETE")}
-													<button
-														on:click={() => {
-															active_deletes[t.id] = true;
-														}}
-														tabindex="0"
-														class="ml-4 text-red-600 hover:text-red-900 cursor-pointer"
-														>{$_("delete")}</button
-													>
-												{/if}
-											</td>
-										{/if}
+											{/if}
+										</td>
 									</tr>
 								{/if}
 							{/each}