From 3abf608b15fcfc2cf65b705d28d394917e7ac333 Mon Sep 17 00:00:00 2001
From: Philipp Dormann <philipp@philippdormann.de>
Date: Wed, 12 Apr 2023 18:56:55 +0200
Subject: [PATCH 1/2] improved tablefilters/groupFilter

---
 src/components/shared/tablefilters.js | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/components/shared/tablefilters.js b/src/components/shared/tablefilters.js
index cbf2abdf..504237e1 100644
--- a/src/components/shared/tablefilters.js
+++ b/src/components/shared/tablefilters.js
@@ -3,13 +3,8 @@ export const groupFilter = (row, columnId, value) => {
     if (group.responseType === "RUNNERORGANIZATION") {
         return group.name.toLowerCase().includes(value.toLowerCase());
     } else if (value.includes(">")) {
-        value = value.split(">")[1];
-        if (value.length == 0) {
-            return group.name.toLowerCase().includes(value.toLowerCase());
-        }
         return (
-            group.name.toLowerCase().includes(value.toLowerCase()) ||
-            group.parentGroup.name.toLowerCase().includes(value.toLowerCase())
+            `${group.parentGroup.name} > ${group.name}`.toLowerCase().includes(value.toLowerCase())
         );
     } else {
         return (

From 94155845f020679e8765d198b5ab4735e1d1142c Mon Sep 17 00:00:00 2001
From: Philipp Dormann <philipp@philippdormann.de>
Date: Wed, 12 Apr 2023 19:00:10 +0200
Subject: [PATCH 2/2] RunnersOverview: add filter keyboard support

---
 src/components/runners/RunnersOverview.svelte | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/components/runners/RunnersOverview.svelte b/src/components/runners/RunnersOverview.svelte
index e20164ab..b14e5dc4 100644
--- a/src/components/runners/RunnersOverview.svelte
+++ b/src/components/runners/RunnersOverview.svelte
@@ -78,7 +78,10 @@
           deleteAction: () => {
             console.log(info.getValue());
           },
-          deleteEnabled: store.state.jwtinfo.userdetails.permissions.includes("RUNNER:DELETE"),
+          deleteEnabled:
+            store.state.jwtinfo.userdetails.permissions.includes(
+              "RUNNER:DELETE"
+            ),
         });
       },
       enableColumnFilter: false,
@@ -181,7 +184,11 @@
             {#each headerGroup.headers as header}
               <th class="cursor-pointer">
                 {#if !header.isPlaceholder}
-                  <div on:click={header.column.getToggleSortingHandler()}>
+                  <button
+                    role="button"
+                    tabindex="0"
+                    on:click={header.column.getToggleSortingHandler()}
+                  >
                     <svelte:component
                       this={flexRender(
                         header.column.columnDef.header,
@@ -193,7 +200,7 @@
                     {:else if header.column.getIsSorted().toString() == "desc"}
                       🔽
                     {/if}
-                  </div>
+                  </button>
                 {/if}
                 {#if header.column.getCanFilter()}
                   <div class="relative max-w-xs">