🚀RELEASE v1.4.6

fix(donor/detail): Set email to null to avoid vaidation errors
fix(donor/detail): Set phone to null to avoid vaidation errors
2023-05-04 20:10:57 +02:00 · 2023-05-04 20:10:21 +02:00 · 2023-05-04 20:09:43 +02:00 · 2023-05-04 20:07:54 +02:00
4 changed files with 16 additions and 11 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -2,10 +2,19 @@

 All notable changes to this project will be documented in this file. Dates are displayed in UTC.

+#### [1.4.6](https://git.odit.services/lfk/frontend/compare/1.4.5...1.4.6)
+
+- fix(donor/details): don't load donations [`a2ff5b8`](https://git.odit.services/lfk/frontend/commit/a2ff5b8a142ce4e6b8876f64935f9787ec44a51e)
+- fix(donor/detail): Set email to null to avoid vaidation errors [`97b57ae`](https://git.odit.services/lfk/frontend/commit/97b57aeb0cc9058542a36dea9c8b2852169c250f)
+- fix(donor/detail): Set phone to null to avoid vaidation errors [`e25ed1f`](https://git.odit.services/lfk/frontend/commit/e25ed1fff9b200605d5d2b78238b774ec7289aaa)
+
 #### [1.4.5](https://git.odit.services/lfk/frontend/compare/1.4.4...1.4.5)

+> 4 May 2023
+
 - Revert "revert: buggy pagination" [`dacb2f8`](https://git.odit.services/lfk/frontend/commit/dacb2f8ace373f6594fc64af133971af053f00c0)
 - fix: Removed dynamic pagesize adjustments [`803d64c`](https://git.odit.services/lfk/frontend/commit/803d64c78caa570d31d6055e70e2d2af6834f04b)
+- 🚀RELEASE v1.4.5 [`0284f18`](https://git.odit.services/lfk/frontend/commit/0284f18beb8b24d4d4d071eca13bc5868666232c)

 #### [1.4.4](https://git.odit.services/lfk/frontend/compare/1.4.3...1.4.4)

--- a/index.html
+++ b/index.html
@ -13,7 +13,7 @@

  <body>
    <span style="display: none; visibility: hidden" id="buildinfo"
-      >RELEASE_INFO-1.4.5-RELEASE_INFO</span
+      >RELEASE_INFO-1.4.6-RELEASE_INFO</span
    >
    <noscript>You need to enable JavaScript to run this app.</noscript>
    <script src="/env.js"></script>
--- a/package.json
+++ b/package.json
@ -1,6 +1,6 @@
 {
  "name": "@odit/lfk-frontend",
-  "version": "1.4.5",
+  "version": "1.4.6",
  "type": "module",
  "scripts": {
    "i18n-order": "node order.js",
--- a/src/components/donors/DonorDetail.svelte
+++ b/src/components/donors/DonorDetail.svelte
@ -12,7 +12,6 @@
  $: delete_triggered = false;
  $: original_data = {};
  $: editable = {};
-  $: current_donations = [];
  $: changes_performed = !(
    JSON.stringify(original_data) === JSON.stringify(editable)
  );
@ -29,11 +28,6 @@
    isPhoneValidOrEmpty &&
    ((isAddress1Valid && iszipcodevalid && iscityvalid) ||
      editable.address_checked === false);
-  const donation_promise = DonationService.donationControllerGetAll().then(
-    (val) => {
-      current_donations = val;
-    }
-  );
  const promise = DonorService.donorControllerGetOne(params.donorid).then(
    (data) => {
      data_loaded = true;
@ -69,7 +63,9 @@
        editable.address = null;
      }
      if (editable.email) editable.email = editable.email;
+      else editable.email = null;
      if (editable.phone) editable.phone = editable.phone;
+      else editable.phone = null;
      if (editable.middlename) editable.middlename = editable.middlename;
      editable.receiptNeeded = editable.address_checked;
      DonorService.donorControllerPut(original_data.id, editable)
@ -96,7 +92,7 @@
 </script>

 <ConfirmDonorDeletion bind:modal_open bind:delete_donor />
-{#await promise && donation_promise}
+{#await promise}
  {$_("loading-donor-details")}
 {:then}
  <section class="container p-5 select-none">
@ -206,8 +202,8 @@
      >
      <br />
      <span class="font-medium text-gray-700">{$_("donations")}:</span>
-      {#if current_donations.filter((d) => d.donor.id == editable.id).length > 0}
-        {#each current_donations.filter((o) => o.donor.id == editable.id) as d}
+      {#if original_data.donations.length > 0}
+        {#each original_data.donations as d}
          {#if d.responseType === "DISTANCEDONATION"}
            <a
              href="../donations/{d.id}"
Author	SHA1	Message	Date
Nicolai Ort	b6fed92a17	🚀RELEASE v1.4.6 All checks were successful continuous-integration/drone/push Build is passing Details	2023-05-04 20:10:57 +02:00
Nicolai Ort	97b57aeb0c	fix(donor/detail): Set email to null to avoid vaidation errors	2023-05-04 20:10:21 +02:00
Nicolai Ort	e25ed1fff9	fix(donor/detail): Set phone to null to avoid vaidation errors	2023-05-04 20:09:43 +02:00
Nicolai Ort	a2ff5b8a14	fix(donor/details): don't load donations	2023-05-04 20:07:54 +02:00