lfk/frontend
2
0
Fork 0
Code Issues 4 Pull Requests Actions Projects Releases Wiki Activity

Know Production Bugs 🐞 #109

Merged
niggl merged 11 commits from bugfix/107-prod_issues into dev 2021-03-25 17:30:29 +00:00
Conversation 3 Commits 11 Files Changed 9
+84 -32
niggl commented 2021-03-25 16:28:48 +00:00
Owner
Copy Link
Copy Source

Fixed the first bug discovered in production.
This one has a high prio b/c it prevents users from logging in...

Edit The branch now also conatins fixes for the following problems:

  • Login with email still fills in the username body
  • Runner Import modal should clear on exit via outerklick
  • Runner Import crashes when no org is provided -> Disable import button when no group is selected
  • Missing translations for scanstations
  • Runner search breaks and drags everything else js down with it

closes #107

Fixed the first bug discovered in production. This one has a high prio b/c it prevents users from logging in... **Edit** The branch now also conatins fixes for the following problems: * Login with email still fills in the username body * Runner Import modal should clear on exit via outerklick * Runner Import crashes when no org is provided -> Disable import button when no group is selected * Missing translations for scanstations * Runner search breaks and drags everything else js down with it closes #107
niggl added the priority:highbugstatus:review_needed labels 2021-03-25 16:28:48 +00:00
niggl added 1 commit 2021-03-25 16:28:49 +00:00
Fixed mail login bug🐞📧 076893981f 
ref #107
niggl requested review from philipp 2021-03-25 16:28:53 +00:00
niggl added 1 commit 2021-03-25 16:31:55 +00:00
Commented out the buggy runner search to prevent bad UX fbe74a5d80 
ref #107
niggl added 1 commit 2021-03-25 16:34:27 +00:00
Fixed outsideclick not clearing import modal🛠 ef49e507c1 
ref #107
niggl added 1 commit 2021-03-25 16:46:17 +00:00
Fixed runner import getting triggered with invalid information ddd9c396b6 
ref #107
niggl added 1 commit 2021-03-25 16:48:57 +00:00
Errors now toast errors❌ 17e0805fe6 
ref #107
niggl added 1 commit 2021-03-25 16:49:15 +00:00
Sorted translations🌍 a1ab65a0e9 
ref #107
niggl changed title from Fixed mail login bug🐞📧 to Know Production Bugs 🐞 2021-03-25 16:50:55 +00:00
niggl added 1 commit 2021-03-25 16:59:52 +00:00
Fixed missing translations for scanstations🌍 aeadef60bb 
ref #107
niggl added 1 commit 2021-03-25 17:00:13 +00:00
Sorted translations 👀 82b1811971 
ref #107
niggl commented 2021-03-25 17:04:47 +00:00
Author
Owner
Copy Link
Copy Source

Update: All bugs except the broken search are fixed (and the sarch ist commented out).

Update: All bugs except the broken search are fixed (and the sarch ist commented out).
niggl added 1 commit 2021-03-25 17:06:31 +00:00
Fixed conflicting css 50fffef13b 
ref #107
niggl added 1 commit 2021-03-25 17:16:16 +00:00
Now disabled search by middlename as a quick workaround 🐞 49e87ccb15 
ref #107
niggl added 1 commit 2021-03-25 17:19:47 +00:00
Removed middlename search from all files that had it 6b92405bae 
ref #107
niggl commented 2021-03-25 17:25:01 +00:00
Author
Owner
Copy Link
Copy Source

@philipp I'd suggest keeping the no middlename search handicap and deal with it when we overhaul the whole search and lists process to accomedate users with machines that aren't potent enough to render > 4000 runners or > 40000 scans

@philipp I'd suggest keeping the no middlename search handicap and deal with it when we overhaul the whole search and lists process to accomedate users with machines that aren't potent enough to render > 4000 runners or > 40000 scans
👍 1
philipp approved these changes 2021-03-25 17:29:48 +00:00
philipp left a comment
Owner
Copy Link
Copy Source

cool, thx 👊

cool, thx 👊
niggl merged commit d2050b5948 into dev 2021-03-25 17:30:29 +00:00
niggl deleted branch 2021-03-25 17:30:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
philipp
Labels
Clear labels
priority:high
bug
Something is not working
 confirmed
The reported bug has been confirmed
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 priority:low
priority:medium
question
More information is needed
 status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Kind/Bug
Something is not working
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Question
A question
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Status/Confirmed
This is indeed a bug/issue
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No labels priority:high bug status:review_needed
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
niggl (Nicolai Ort) philipp (Philipp Dormann)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/frontend#109