lfk/frontend
2
0
Fork 0
Code Issues 3 Pull Requests Actions Projects Releases Wiki Activity

AddRunnerModal does not trap focus as expected #121

New Issue
Closed
opened 2021-04-05 10:15:00 +00:00 by philipp · 2 comments
philipp commented 2021-04-05 10:15:00 +00:00
Owner
Copy Link

expected

focus should be trapped in modal for accessibility reasons

actual

focus is not properly trapped in modal

reproduction

  • go to /runners/
  • click on add runner
  • focus in Firstname input field (should be focused when opening modal)
  • press SHIFT+TAB on your keyboard
  • 🐞 delete on last runner table row will be in focus
### expected focus should be trapped in modal for accessibility reasons ### actual focus is not properly trapped in modal ### reproduction - go to `/runners/` - click on `add runner` - focus in `Firstname` input field (should be focused when opening modal) - press `SHIFT`+`TAB` on your keyboard - 🐞 `delete` on last runner table row will be in focus
philipp added the
confirmed
bug
 labels 2021-04-05 10:15:00 +00:00
philipp commented 2021-04-05 10:16:45 +00:00
Author
Owner
Copy Link

the same bug happens in

  • ImportRunnerModal
  • AddGroupModal
  • AddUserModal
  • ... (everywhere??)
the same bug happens in - ImportRunnerModal - AddGroupModal - AddUserModal - ... (everywhere??)
niggl added the
wontfix
 label 2021-04-05 14:50:24 +00:00
niggl commented 2021-04-05 14:51:13 +00:00
Owner
Copy Link

Bug in dependency: svelte-focus-trap

Bug in dependency: [svelte-focus-trap](https://www.npmjs.com/package/svelte-focus-trap)
niggl closed this issue 2021-04-05 14:51:13 +00:00
niggl reopened this issue 2021-04-05 14:54:58 +00:00
niggl closed this issue 2021-04-05 15:02:03 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
confirmed
The reported bug has been confirmed
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
priority:low
priority:medium
question
More information is needed
status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
bug
confirmed
wontfix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/frontend#121
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?