lfk/frontend
2
0
Fork 0
Code Issues 3 Pull Requests Actions Projects Releases Wiki Activity

Make dropdowns (selects) searchable feature/91-searchable_dropdowns #97

Merged
niggl merged 35 commits from feature/91-searchable_dropdowns into dev 2021-03-17 16:05:21 +00:00
Conversation 1 Commits 35 Files Changed 14 +989 -902
niggl commented 2021-03-17 10:17:21 +00:00
Owner
Copy Link

Pretty much what the title says.
I replaced all select dropdowns with svelte select to make the stuff searchable and overall a little bit smoother.

This also enables us to load the dropdown contents async in the future.

Imo ux++
closes #91

Pretty much what the title says. I replaced all select dropdowns with svelte select to make the stuff searchable and overall a little bit smoother. This also enables us to load the dropdown contents async in the future. Imo ux++ closes #91
niggl added the
status:review_needed
 label 2021-03-17 10:17:21 +00:00
niggl added 32 commits 2021-03-17 10:17:22 +00:00 
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
ref #91
# Conflicts:
#	src/locales/de.json
#	src/locales/en.json
ref #91
niggl requested review from philipp 2021-03-17 10:17:26 +00:00
niggl added 1 commit 2021-03-17 16:01:12 +00:00 
ref #91
niggl added 2 commits 2021-03-17 16:02:46 +00:00 
ref #91
philipp approved these changes 2021-03-17 16:05:03 +00:00
philipp left a comment
Owner
Copy Link

LGTM ✅

keyboard accessibility should be fixed in a new task 👍

LGTM ✅ keyboard accessibility should be fixed in a new task 👍
niggl merged commit b541c93797 into dev 2021-03-17 16:05:21 +00:00
niggl deleted branch 2021-03-17 16:05:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
philipp
Labels
Clear labels
bug
Something is not working
confirmed
The reported bug has been confirmed
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
priority:low
priority:medium
question
More information is needed
status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
status:review_needed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/frontend#97
No description provided.
Delete Branch "feature/91-searchable_dropdowns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?