From ba604f77e9ce770e60f032cf393a5987a0401fbe Mon Sep 17 00:00:00 2001
From: Philipp Dormann <philipp@philippdormann.de>
Date: Wed, 31 Mar 2021 19:03:07 +0200
Subject: [PATCH] added env config instructions

ref #27
---
 README.md            | 16 ++++++++++++----
 public/env.sample.js |  6 +++---
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/README.md b/README.md
index 5eda5c2..773bb9c 100644
--- a/README.md
+++ b/README.md
@@ -4,7 +4,7 @@ runner selfservice portal
 
 ## ⚡ Development
 ### Requirements
-- Node.js v14.15.0 or newer
+- Node.js v14.16.0 or newer
 - yarn package manager >= v1.22.10 < 2
 
 ### Recommended Extensions
@@ -14,9 +14,17 @@ runner selfservice portal
 ### Fastest Dev Environment
 - You can install the [Remote - Containers](https://github.com/Microsoft/vscode-remote-release) extension and use all recommended extensions and editor settings via the provided `./devcontainer/` config
 
-## 🔨 environment config
+### Manual Dev Environment
+```
+yarn && yarn dev --open
+```
+
+## 🔨 Environment config
 - copy the `/public/env.sample.js` file to `/public/env.js`
 - set the required environment variables
   - `documentserver_key`: url to the [document server](https://git.odit.services/lfk/document-server) instance
-  - `baseurl`: url to the main instance
-  - see [@lfk/deployment](https://git.odit.services/lfk/deployment) for a complete deployment guide
\ No newline at end of file
+  - `baseurl`: url to the main lfk instance - WITH TRAILING SLASH
+  - see [@lfk/deployment](https://git.odit.services/lfk/deployment) for a complete deployment guide
+  - `baseurl_selfservice`: location of the selfservice instance - WITH TRAILING SLASH
+    - e.g. path: `/selfservice/`
+    - e.g. url: `https://example.com/selfservice/`
\ No newline at end of file
diff --git a/public/env.sample.js b/public/env.sample.js
index 1b7072a..c6c0e42 100644
--- a/public/env.sample.js
+++ b/public/env.sample.js
@@ -1,10 +1,10 @@
 const config = {
 	// required
 	documentserver_key: '',
-	// required
+	// required, with trailing slash
 	baseurl: '',
-	// optional, will fallback to /selfservice
-	baseurl_selfservice: '/selfservice',
+	// optional, will fallback to /selfservice/
+	baseurl_selfservice: '/selfservice/',
 	// optional, will fallback to /imprint
 	url_imprint: '',
 	// optional, will fallback to /privacy