refactor: make Donation.donor optional
This commit is contained in:
		| @@ -1,6 +1,5 @@ | ||||
| import { IsInt, IsOptional, IsPositive } from 'class-validator'; | ||||
| import { getConnection } from 'typeorm'; | ||||
| import { DonorNotFoundError } from '../../../errors/DonorErrors'; | ||||
| import { Donation } from '../../entities/Donation'; | ||||
| import { Donor } from '../../entities/Donor'; | ||||
|  | ||||
| @@ -14,6 +13,7 @@ export abstract class CreateDonation { | ||||
|      */ | ||||
|     @IsInt() | ||||
|     @IsPositive() | ||||
|     @IsOptional() | ||||
|     donor: number; | ||||
|  | ||||
|     /** | ||||
| @@ -33,9 +33,6 @@ export abstract class CreateDonation { | ||||
|      */ | ||||
|     public async getDonor(): Promise<Donor> { | ||||
|         const donor = await getConnection().getRepository(Donor).findOne({ id: this.donor }); | ||||
|         if (!donor) { | ||||
|             throw new DonorNotFoundError(); | ||||
|         } | ||||
|         return donor; | ||||
|     } | ||||
| } | ||||
| @@ -1,6 +1,5 @@ | ||||
| import { | ||||
|   IsInt, | ||||
|   IsNotEmpty | ||||
|   IsInt | ||||
| } from "class-validator"; | ||||
| import { Column, Entity, ManyToOne, PrimaryGeneratedColumn, TableInheritance } from "typeorm"; | ||||
| import { ResponseDonation } from '../responses/ResponseDonation'; | ||||
| @@ -24,7 +23,6 @@ export abstract class Donation { | ||||
|   /** | ||||
|    * The donations's donor. | ||||
|    */ | ||||
|   @IsNotEmpty() | ||||
|   @ManyToOne(() => Donor, donor => donor.donations) | ||||
|   donor: Donor; | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user