Updated the put methods and cleaned up a shitload of comments #42

niggl · 2020-12-21T15:22:58Z

niggl commented

2020-12-21 15:22:58 +00:00

If the tests run sucessfully this should be a no-brainer.

niggl added this to the Base-System milestone 2020-12-21 15:22:58 +00:00

niggl self-assigned this 2020-12-21 15:22:58 +00:00

niggl added 30 commits 2020-12-21 15:22:59 +00:00

Renamed function to better reflect it's function 3850bd9681

ref #39

removed useless deletes adec2bcc5b

ref #39

Fixed wrong error type b55d210aff

ref #39

Added missing username property to the responseuser cf583a22fa

ref #39

Moved runner teams to the new put mechanism 24de82f6df

ref #39

Moved runners to the new put mechanism cc68948a20

ref #39

Moved permissions to the new put mechanism b2bd6173a5

ref #39

Fixed some weired toString beviour ec4d75128b

ref #39 #6

Moved usergroups to the new put mechanism 18ede29ea5

ref #39

Switched runner orgs to the cleaner syntax via a update entity 532b5a56a5

ref #39

Moved tracks to the new put mechanism fbe2b358bd

ref #39

Fixed some stuff not getting checked against null 7a4238f1f7

ref #39 gosh i sometimes hate js types

Fixed messages and comments for AuthErrors 4ca85a1f22

ref #39

Fixed messages and comments for PermissionErrors c1d784e29c

ref #39

Fixed messages and comments for RunnerErrors 5de81ad093

ref #39

Fixed messages and comments for RunnerGroupErrors 82ced34750

ref #39

Fixed messages and comments for RunnerOrganisationErrors 37afc10e44

ref #39

Fixed messages and comments for RunnerTeamErrors 389f6347c3

ref #39

Fixed messages and comments for TrackErrors + spelling for some other errors 75b6489f8d

ref #39

Fixed messages and comments for UserErrors ee76f1c0e8

ref #39

Fixed messages and comments for UserGroupErrors 2199cb0aef

ref #39

Added a missing poiunt/exclamation mark de91d491e5

ref #39

Updated loader comments and descriptions 43a4f1118d

ref #39

Code + Comment cleanup for the middlewares a88c0389c1

ref #39

Code + comment cleanup for the seeds a85d52437b

ref #39

Code + comment cleanup for the response models 75332983c2

ref #39

Code + comment cleanup for the enums a03f1a438d

ref #39

Code + comment cleanup for the entities d20d738218

ref #39

First part of the action comment refactoring 1d0d79f3da

ref #39
Why did i volunteer for this? It's just a glorified sleeping aid 😴

Second part of the action comment refactoring

continuous-integration/drone/pr Build is failing

Details

48bef8db60

ref #39

niggl requested review from philipp 2020-12-21 15:23:04 +00:00

niggl added 1 commit 2020-12-21 15:58:55 +00:00

Small bugfix

continuous-integration/drone/pr Build is failing

Details

0ef6d9cc48

ref #39

niggl added 1 commit 2020-12-21 16:22:11 +00:00

Reverted simplification that created loops

continuous-integration/drone/pr Build is passing

Details

7d5f3b092f

ref #39

philipp approved these changes 2020-12-21 16:38:18 +00:00

niggl referenced this issue from a commit

2020-12-21 16:39:20 +00:00

Merge pull request 'Updated the put methods and cleaned up a shitload of comments' (#42) from feature/39-update_puts into dev

niggl merged commit 1bf6d3d564 into dev

2020-12-21 16:39:21 +00:00

niggl deleted branch

2020-12-21 16:40:12 +00:00

~~niggl referenced this pull request 2020-12-21 16:42:17 +00:00~~

Load postal code validation country from env/config #43

niggl referenced this pull request

2020-12-21 16:42:40 +00:00

Move all put requests to the new update mechanism implemented in #37 #39

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lfk/backend#42