Updated the put methods and cleaned up a shitload of comments #42

niggl · 2020-12-21T15:22:58Z

niggl commented

2020-12-21 15:22:58 +00:00

If the tests run sucessfully this should be a no-brainer.

niggl added this to the Base-System milestone 2020-12-21 15:22:58 +00:00

niggl self-assigned this 2020-12-21 15:22:58 +00:00

niggl added 30 commits 2020-12-21 15:22:59 +00:00

3850bd9681 Renamed function to better reflect it's function

ref #39

adec2bcc5b removed useless deletes

ref #39

b55d210aff Fixed wrong error type

ref #39

cf583a22fa Added missing username property to the responseuser

ref #39

24de82f6df Moved runner teams to the new put mechanism

ref #39

cc68948a20 Moved runners to the new put mechanism

ref #39

b2bd6173a5 Moved permissions to the new put mechanism

ref #39

ec4d75128b Fixed some weired toString beviour

ref #39 #6

18ede29ea5 Moved usergroups to the new put mechanism

ref #39

532b5a56a5 Switched runner orgs to the cleaner syntax via a update entity

ref #39

fbe2b358bd Moved tracks to the new put mechanism

ref #39

7a4238f1f7 Fixed some stuff not getting checked against null

ref #39 gosh i sometimes hate js types

4ca85a1f22 Fixed messages and comments for AuthErrors

ref #39

c1d784e29c Fixed messages and comments for PermissionErrors

ref #39

5de81ad093 Fixed messages and comments for RunnerErrors

ref #39

82ced34750 Fixed messages and comments for RunnerGroupErrors

ref #39

37afc10e44 Fixed messages and comments for RunnerOrganisationErrors

ref #39

389f6347c3 Fixed messages and comments for RunnerTeamErrors

ref #39

75b6489f8d Fixed messages and comments for TrackErrors + spelling for some other errors

ref #39

ee76f1c0e8 Fixed messages and comments for UserErrors

ref #39

2199cb0aef Fixed messages and comments for UserGroupErrors

ref #39

de91d491e5 Added a missing poiunt/exclamation mark

ref #39

43a4f1118d Updated loader comments and descriptions

ref #39

a88c0389c1 Code + Comment cleanup for the middlewares

ref #39

a85d52437b Code + comment cleanup for the seeds

ref #39

75332983c2 Code + comment cleanup for the response models

ref #39

a03f1a438d Code + comment cleanup for the enums

ref #39

d20d738218 Code + comment cleanup for the entities

ref #39

1d0d79f3da First part of the action comment refactoring

ref #39
Why did i volunteer for this? It's just a glorified sleeping aid 😴

continuous-integration/drone/pr Build is failing Details

48bef8db60 Second part of the action comment refactoring

ref #39

niggl requested review from philipp 2020-12-21 15:23:04 +00:00

niggl added 1 commit 2020-12-21 15:58:55 +00:00

continuous-integration/drone/pr Build is failing Details

0ef6d9cc48 Small bugfix

ref #39

niggl added 1 commit 2020-12-21 16:22:11 +00:00

continuous-integration/drone/pr Build is passing Details

7d5f3b092f Reverted simplification that created loops

ref #39

philipp approved these changes 2020-12-21 16:38:18 +00:00

niggl referenced this issue from a commit

2020-12-21 16:39:20 +00:00

Merge pull request 'Updated the put methods and cleaned up a shitload of comments' (#42) from feature/39-update_puts into dev

niggl merged commit 1bf6d3d564 into dev

2020-12-21 16:39:21 +00:00

niggl deleted branch

2020-12-21 16:40:12 +00:00

~~niggl referenced this pull request 2020-12-21 16:42:17 +00:00~~

Load postal code validation country from env/config #43

niggl referenced this pull request

2020-12-21 16:42:40 +00:00

Move all put requests to the new update mechanism implemented in #37 #39

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lfk/backend#42