Bug: Address circular dependency #68

New Issue

niggl · 2021-01-02T18:35:05Z

niggl commented

2021-01-02 18:35:05 +00:00

With the implementation of the donor api endpoints a new bug surfaced.
Due to the way address entities and their relations are currently implemented they cause a circular depdendency.

To be more exact - this part causes the problem:

  /**
   * Used to link the address to participants.
   */
  @OneToMany(() => Participant, participant => participant.address, { nullable: true })
  participants: Participant[];

  /**
   * Used to link the address to runner groups.
   */
  @OneToMany(() => RunnerOrganisation, group => group.address, { nullable: true })
  groups: RunnerOrganisation[];

Due to this bug addresses for organisations are currently disabled in all branches following #65 (or in which #65 has been merged into).

TODO:

Find a solution to fix the circular dependency
Add addresses back into all actions
Add addresses back into all tests

With the implementation of the donor api endpoints a new bug surfaced. Due to the way address entities and their relations are currently implemented they cause a circular depdendency. To be more exact - this part causes the problem: ```typescript /** * Used to link the address to participants. */ @OneToMany(() => Participant, participant => participant.address, { nullable: true }) participants: Participant[]; /** * Used to link the address to runner groups. */ @OneToMany(() => RunnerOrganisation, group => group.address, { nullable: true }) groups: RunnerOrganisation[]; ``` Due to this bug addresses for organisations are currently disabled in all branches following #65 (or in which #65 has been merged into). TODO: * [ ] Find a solution to fix the circular dependency * [ ] Add addresses back into all actions * [ ] Add addresses back into all tests

niggl added this to the Donations&Scans milestone 2021-01-02 18:35:05 +00:00

niggl added the

status:doing

priority:high

bug

labels 2021-01-02 18:35:05 +00:00

niggl referenced this issue

2021-01-02 18:35:39 +00:00

New Feature: Donor endpoints feature/65-donor_controllers #69

niggl referenced this issue from a commit

2021-01-02 18:39:03 +00:00

Added todo relateing to the bugfix issue