New Feature: Donor endpoints feature/65-donor_controllers #69

Merged

niggl merged 30 commits from feature/65-donor_controllers into dev 2021-01-02 21:06:11 +00:00

Conversation 2 Commits 30 Files Changed 22

+582 -51

niggl commented 2021-01-02 18:35:39 +00:00

Owner

Copy Link

Copy Source

closes #65

I added the endpoints for donor creation, updateing, deletion and getting + Tests for them.
Everything else donor related will be handeled over in #66

Meanwhile a bug arose concerning circular dependencies that i'm going to work on over in #68 (branched out from this pr)

closes #65 I added the endpoints for donor creation, updateing, deletion and getting + Tests for them. Everything else donor related will be handeled over in #66 Meanwhile a bug arose concerning circular dependencies that i'm going to work on over in #68 (branched out from this pr)

niggl added this to the Donations&Scans milestone 2021-01-02 18:35:39 +00:00

niggl added 22 commits 2021-01-02 18:35:40 +00:00

Added new donor permission target ... 9d9549cdd4

ref #65

Added copy of runnerController with some stuff reanames for donors ... 4126d31a5e

ref #65

Added donor response class ... e46cfa0d77

ref #65

Added the base logic for donor getters ... 3df1db4ad8

ref #65

Implemented basic donor deletion ... 61a17b198f

ref #65

Added first donor-specific errors ... a83fedc9b8

ref #65

Added everything for basic donor creation ... 557608e318

ref #65

Added basic runner updateing ... ab67e5f4aa

ref #65

Extended todo w/ issue link ... c9ba69792f

ref #65

Mitigated circular dependency (to be fixed) ... 1dc438beb2

ref #65

Fixed not null constraint ... 53548ba7a6

ref #56

Fixed not null constraint ... 52cdd41ec8

ref #65

Merge branch 'feature/65-donor_controllers' of git.odit.services:lfk/backend into feature/65-donor_controllers becc277123

Added address check for donors that want a receipt ... 335d4e24da

ref #65

Added address check for donors that want a receipt on update ... 2594a607dc

ref #65

Removed addresses from tests until the circular dependencies are solved ... 599296c4e3

ref #65

Updated track tests for paralellism ... 82a0e194cb

ref #65

Added donor get tests ... b337ab424d

ref #65

Added donor post (add) tests ... e4c1930dd1

ref #65

Added donor add test for address needed error ... f9e314bf9f

ref #65

Added donor delete tests ... 17c82ff409

ref #65

Added donor put (update) tests ... deb13674b2

ref #65

niggl added 1 commit 2021-01-02 18:39:06 +00:00

Added todo relateing to the bugfix issue ... 9b5d16ae92

ref #65 #68

niggl marked the pull request as work in progress 2021-01-02 19:03:46 +00:00

niggl added a new dependency 2021-01-02 19:05:08 +00:00

#70 bugfix/68-address_circular_dependencies

niggl commented 2021-01-02 19:05:12 +00:00

Author

Owner

Copy Link

Copy Source

Marked as wip until the bugfix is merged (#70)

Marked as wip until the bugfix is merged (#70)

niggl requested review from philipp 2021-01-02 19:05:33 +00:00

niggl added 6 commits 2021-01-02 20:55:07 +00:00

Implemented a possible bugfix ... 2c47436259

ref #68

Added comments to the bugfix 9c4e54fc6e

Revert "Removed addresses from tests until the circular dependencies are solved" ... 56c6a7efb0

This reverts commit 599296c4e3.

Reenabled addresses in org responses ... 1e2de7656e

ref #68

Change requested by @philipp ... 97e8470b0d

ref #70

Merge pull request 'bugfix/68-address_circular_dependencies' (#70) from bugfix/68-address_circular_dependencies into feature/65-donor_controllers ... 92186a86cc

Reviewed-on: #70
closes #68

niggl marked the pull request as ready for review 2021-01-02 20:55:26 +00:00

niggl added 1 commit 2021-01-02 20:55:37 +00:00

Merge branch 'dev' into feature/65-donor_controllers 3090ae69f3

philipp approved these changes 2021-01-02 21:05:18 +00:00

philipp left a comment

Owner

Copy Link

Copy Source

nice! 🚀

nice! 🚀

niggl referenced this issue from a commit 2021-01-02 21:06:09 +00:00

Merge pull request 'New Feature: Donor endpoints feature/65-donor_controllers' (#69) from feature/65-donor_controllers into dev

niggl merged commit 39857cf6e6 into dev 2021-01-02 21:06:11 +00:00

niggl deleted branch 2021-01-02 21:06:22 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

philipp

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

priority:high

priority:low

priority:medium

question

More information is needed

status:blocked

status:doing

status:review_needed

wontfix

This won't be fixed

Kind/Bug

Something is not working

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Question

A question

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Status/Confirmed

This is indeed a bug/issue

Complexity

Easy

The complexity is low

Complexity

Hard

The complexity is high

Complexity

Medium

The complexity is medium

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Doing

Somebody is working on this

Status

Need More Info

Feedback is required to reproduce issue or to continue work

Status

Review needed

Needs a reveiw

No labels

Milestone

No items

No Milestone Donations&Scans

Projects

Clear projects

No projects

Assignees

Clear assignees

niggl (Nicolai Ort) philipp (Philipp Dormann)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Depends on

#70 bugfix/68-address_circular_dependencies

lfk/backend

Reference: lfk/backend#69