lfk/backend
2
0
Fork 0
Code Issues 1 Pull Requests Actions Projects Releases 40 Activity

feature/78-trackscan #85

Merged
niggl merged 15 commits from feature/78-trackscan into dev 2021-01-09 16:33:12 +00:00
Conversation 2 Commits 15 Files Changed 17 +881 -56
niggl commented 2021-01-09 16:19:20 +00:00
Owner
Copy Link

closes #78

closes #78
niggl added 15 commits 2021-01-09 16:19:21 +00:00 
ref #78
ref #78
ref #78
ref #78
ref #78
ref #78
# Conflicts:
#	src/controllers/RunnerController.ts
ref #78
ref #78
ref #78
ref #78
ref #78
ref #78
ref #78
added trackscan update tests
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7e95103a2d 
ref #78
niggl added this to the Donations&Scans milestone 2021-01-09 16:19:25 +00:00
niggl requested review from philipp 2021-01-09 16:19:30 +00:00
philipp approved these changes 2021-01-09 16:30:16 +00:00
philipp left a comment
Owner
Copy Link

tests pass + code looks good to me (apart from the formatting which we gotta deal with in #9)
🚢🚀🚢

tests pass + code looks good to me (apart from the formatting which we gotta deal with in #9) 🚢🚀🚢
niggl commented 2021-01-09 16:33:01 +00:00
Author
Owner
Copy Link

Yeah first part of function name refactoring will happen over in #76 as the next step.
And ofc #9 is still a thing if anyone wants to volunteer ;)

Yeah first part of function name refactoring will happen over in #76 as the next step. And ofc #9 is still a thing if anyone wants to volunteer ;)
niggl merged commit 80197d5834 into dev 2021-01-09 16:33:11 +00:00
niggl deleted branch 2021-01-09 16:33:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
philipp
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
priority:low
priority:medium
question
More information is needed
status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
Milestone
No items
No Milestone Donations&Scans
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/backend#85
No description provided.
Delete Branch "feature/78-trackscan"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?