lfk/backend
2
0
Fork 0
Code Issues 1 Pull Requests Actions Projects Releases 40 Activity

Cleanup: Method nameing and folder sort #76

New Issue
Closed
opened 2021-01-07 17:59:28 +00:00 by niggl · 1 comment
niggl commented 2021-01-07 17:59:28 +00:00
Owner
Copy Link

For the sake of consistency all .toXY function in the create classes should just be named "toEntity". This would greatly benefit every programmer and streamline the nameing scheme.

While we're at it we should also clean up methods (delete to be exact) that don't accept all of the usual parameters.

And since the models/actions folder is getting pretty full i hereby propose the creation of the subfolders models/actions/create and models/actions/update.
Imo everything not fitting in the categories should just reside in the models/actions folder.

@philipp What's you opinion concerning the folder proposal?

For the sake of consistency all .toXY function in the create classes should just be named "toEntity". This would greatly benefit every programmer and streamline the nameing scheme. While we're at it we should also clean up methods (delete to be exact) that don't accept all of the usual parameters. And since the models/actions folder is getting pretty full i hereby propose the creation of the subfolders `models/actions/create` and `models/actions/update`. Imo everything not fitting in the categories should just reside in the `models/actions` folder. @philipp What's you opinion concerning the folder proposal?
niggl added this to the Project Quality of Life/Dev milestone 2021-01-07 17:59:28 +00:00
niggl added the
enhancement
priority:medium
 labels 2021-01-07 17:59:28 +00:00
niggl added a new dependency 2021-01-07 17:59:36 +00:00
#67 Scan API
niggl added a new dependency 2021-01-08 19:58:44 +00:00
#77 Runner Cards
niggl added a new dependency 2021-01-09 16:34:10 +00:00
#66 Donation API
niggl referenced this issue from a commit 2021-01-10 15:07:39 +00:00
Fixed some typos in errors
niggl added the
status:doing
 label 2021-01-10 15:23:26 +00:00
niggl referenced this issue from a commit 2021-01-10 15:24:29 +00:00
Updated imports
niggl removed a dependency 2021-01-10 16:13:28 +00:00
#66 Donation API
niggl commented 2021-01-10 16:13:38 +00:00
Author
Owner
Copy Link

Cleaned up:

  • Method nameing
  • models/actions folder structure
  • OpenAPI spec generation
Cleaned up: * Method nameing * models/actions folder structure * OpenAPI spec generation
niggl referenced this issue from a commit 2021-01-10 16:16:44 +00:00
Unified remove parameters
niggl referenced this issue from a commit 2021-01-10 16:29:32 +00:00
Dependency bump
niggl referenced this issue from a commit 2021-01-10 16:47:33 +00:00
Implmented basic release mgnt
niggl closed this issue 2021-01-10 17:11:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
priority:low
priority:medium
question
More information is needed
status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
enhancement
priority:medium
status:doing
Milestone
No items
No Milestone Project Quality of Life/Dev
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#67 Scan API
lfk/backend
#77 Runner Cards
lfk/backend
Reference: lfk/backend#76
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?