lfk/frontend
2
0
Fork 0
Code Issues 3 Pull Requests Actions Projects Releases Wiki Activity

feature/12-user-management #39

Merged
philipp merged 21 commits from feature/12-user-management into dev 2021-01-26 16:29:01 +00:00
Conversation 6 Commits 21 Files Changed 8 +380 -146
philipp commented 2021-01-24 20:44:43 +00:00
Owner
Copy Link

closes #12

closes #12
philipp added this to the Base-System milestone 2021-01-24 20:44:43 +00:00
philipp added the
enhancement
 label 2021-01-24 20:44:43 +00:00
niggl was assigned by philipp 2021-01-24 20:44:43 +00:00
philipp added 16 commits 2021-01-24 20:44:44 +00:00 
ref #12
ref #12
ref #12
ref #12
ref #12
ref #12
ref #12
ref #12
ref #12
ref #12
ref #12
ref #12
ref #12
philipp requested review from niggl 2021-01-24 20:44:47 +00:00
niggl added 1 commit 2021-01-24 20:50:41 +00:00 
# Conflicts:
#	src/components/UserDetail.svelte
niggl changed title from feature/12-user-management to WIP: feature/12-user-management 2021-01-24 20:57:41 +00:00
niggl requested changes 2021-01-24 20:58:00 +00:00
niggl left a comment
Owner
Copy Link

We found a bug.
@philipp is on it soon (tm)

We found a bug. @philipp is on it soon (tm)
philipp commented 2021-01-25 19:47:09 +00:00
Author
Owner
Copy Link

🐞 bug description

  • clicking on UserDetail will load all permissions
  • permission color is loaded from colors array which will be out of index when the permission targets are out of alphabetical order

✨possible solutions

  • order permissions by target in frontend
### 🐞 bug description - clicking on UserDetail will load all permissions - permission color is loaded from `colors` array which will be out of index when the permission targets are out of alphabetical order ### ✨possible solutions - order permissions by target in frontend
philipp added 1 commit 2021-01-25 19:56:23 +00:00 
ref #39 ref #12
philipp changed title from WIP: feature/12-user-management to feature/12-user-management 2021-01-25 19:56:29 +00:00
philipp requested review from niggl 2021-01-25 19:56:44 +00:00
philipp commented 2021-01-25 19:57:18 +00:00
Author
Owner
Copy Link

bug should be resolved, thanks for the test @niggl 🤝

bug should be resolved, thanks for the test @niggl 🤝
niggl commented 2021-01-26 13:44:18 +00:00
Owner
Copy Link

Found another thing (not a bug per se).
After removeing a user from a group and saveing them the old groups permissions still reside in the userdetail "Permissions" section.
This changes on reload.

If if is possible to adjust this beahavior id'd prefer it.
If it ain't: Consider this approval.

Found another thing (not a bug per se). After removeing a user from a group and saveing them the old groups permissions still reside in the userdetail "Permissions" section. This changes on reload. If if is possible to adjust this beahavior id'd prefer it. If it ain't: Consider this approval.
niggl commented 2021-01-26 13:47:39 +00:00
Owner
Copy Link

Same the other way around btw ^^

Same the other way around btw ^^
philipp added 2 commits 2021-01-26 16:27:47 +00:00 
# Conflicts:
#	src/App.svelte
ref #12
philipp added 1 commit 2021-01-26 16:28:11 +00:00 
ref #12
niggl approved these changes 2021-01-26 16:28:44 +00:00
niggl left a comment
Owner
Copy Link

thx 4 implementing the requested changes.
👊

thx 4 implementing the requested changes. 👊
philipp merged commit d48b9b7f91 into dev 2021-01-26 16:29:00 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
niggl
Labels
Clear labels
bug
Something is not working
confirmed
The reported bug has been confirmed
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
priority:low
priority:medium
question
More information is needed
status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
enhancement
Milestone
No items
No Milestone Base-System
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees niggl
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/frontend#39
No description provided.
Delete Branch "feature/12-user-management"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?