lfk/frontend
2
0
Fork 0
Code Issues 3 Pull Requests Actions Projects Releases Wiki Activity

Implmented certificate generation feature/119-Certificate_generation #120

Merged
niggl merged 25 commits from feature/119-Certificate_generation into dev 2021-04-05 14:05:40 +00:00
Conversation 5 Commits 25 Files Changed 11 +340 -11
niggl commented 2021-04-03 18:05:05 +00:00
Owner
Copy Link

Runner certificate generation via:

  • Runner overview
  • Runner Detail
  • Team Overview
  • Team Detail
  • Org overview
  • Org Detail

closes #119

Runner certificate generation via: * Runner overview * Runner Detail * Team Overview * Team Detail * Org overview * Org Detail closes #119
niggl added 14 commits 2021-04-03 18:05:05 +00:00 
ref #119
ref #119
ref #119
ref #119
ref #119
ref #119
ref #119
ref #119
ref #119
ref #119
ref #119
ref #119
ref #119
niggl added 1 commit 2021-04-03 18:05:31 +00:00 
ref #119
niggl requested review from philipp 2021-04-03 18:05:32 +00:00
niggl added the
status:review_needed
 label 2021-04-03 18:05:36 +00:00
philipp added 1 commit 2021-04-05 10:02:24 +00:00 
ref #119
philipp requested changes 2021-04-05 10:08:08 +00:00
philipp left a comment
Owner
Copy Link
  • there is no button in OrgDetail
  • wrong german translation in RunnerDetail: "Urkunden herunterladen" -> fixed by me; added new translation
  • maybe the certificate files could be named "Urkunde_${firstname}_${lastname}.pdf"
    • language specific prefix
    • user/ team/ org information (teams already seem to work? (only the postfix))

small heads up: translations were not ordered/ formatted correctly. maybe a vscode setting?

- there is no button in OrgDetail - wrong german translation in RunnerDetail: "Urkunden herunterladen" **-> fixed by me; added new translation** - maybe the certificate files could be named "Urkunde_${firstname}_${lastname}.pdf" - language specific prefix - user/ team/ org information (teams already seem to work? (only the postfix)) small heads up: translations were not ordered/ formatted correctly. maybe a vscode setting?
niggl commented 2021-04-05 10:11:51 +00:00
Author
Owner
Copy Link
  • Urkunde_${firstname}_${lastname}.pdf -> Wouldn't be following the scheme set by all other pdf generation/downloading function
  • language specific prefix -> Also not follwoing the scheme (should be adjusted everywhere)

And what do you mean by user/org/team/information, @philipp ?

* Urkunde_${firstname}_${lastname}.pdf -> Wouldn't be following the scheme set by all other pdf generation/downloading function * language specific prefix -> Also not follwoing the scheme (should be adjusted everywhere) And what do you mean by user/org/team/information, @philipp ?
niggl commented 2021-04-05 13:22:36 +00:00
Author
Owner
Copy Link

Hey @philipp I can't reproduce the "there is no button in OrgDetail" bug.
Code contains the button and yarn dev/build output also shows it.

It got implemented in e6ffc371e1

Screenshots

image
image

Hey @philipp I can't reproduce the "there is no button in OrgDetail" bug. Code contains the button and yarn dev/build output also shows it. It got implemented in e6ffc371e1ca2d4451e7dd4a3ca3c05564edb5fb ## Screenshots ![image](/attachments/a3fc0dfd-4c26-40e7-8913-47a6c0765c85) ![image](/attachments/0017ac6a-81d7-47e4-a2aa-28c1de5fa7b0)
image.png
6.3 KiB
image.png
48 KiB
niggl added 1 commit 2021-04-05 13:24:45 +00:00 
ref #119
niggl added 1 commit 2021-04-05 13:28:16 +00:00 
ref #119
niggl added 1 commit 2021-04-05 13:31:04 +00:00 
ref #119
niggl added 1 commit 2021-04-05 13:31:54 +00:00 
ref #119
niggl added 1 commit 2021-04-05 13:33:58 +00:00 
ref #119
niggl added 1 commit 2021-04-05 13:36:04 +00:00 
ref #119
niggl added 1 commit 2021-04-05 13:37:17 +00:00 
ref #119
niggl commented 2021-04-05 13:39:12 +00:00
Author
Owner
Copy Link

Changed the pdf name scheme:

  • Org: _<name>-<locale>
  • Team: _<name>-<locale>
  • Runners: -<locale>
  • Runner(single): _<firstname>_<lastname>-<locale>
Changed the pdf name scheme: * Org: `_<name>-<locale>` * Team: `_<name>-<locale>` * Runners: `-<locale>` * Runner(single): `_<firstname>_<lastname>-<locale>`
niggl added 1 commit 2021-04-05 14:04:29 +00:00 
ref #119
niggl added 1 commit 2021-04-05 14:04:47 +00:00 
ref #119
niggl requested review from philipp 2021-04-05 14:04:52 +00:00
philipp approved these changes 2021-04-05 14:05:01 +00:00
niggl merged commit f0738d451b into dev 2021-04-05 14:05:40 +00:00
niggl deleted branch 2021-04-05 14:05:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
philipp
Labels
Clear labels
bug
Something is not working
confirmed
The reported bug has been confirmed
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
priority:low
priority:medium
question
More information is needed
status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
status:review_needed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/frontend#120
No description provided.
Delete Branch "feature/119-Certificate_generation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?