lfk/frontend

Spnonsoring contract language selector feature/84-sponsoringcontract_language_selector #89

Merged

niggl merged 11 commits from feature/84-sponsoringcontract_language_selector into dev

2021-03-01 16:45:08 +00:00

niggl commented

2021-02-28 15:36:23 +00:00

Owner

Users can now select the language that they want to use to generate sponsoring contracts.

closes #84

Users can now select the language that they want to use to generate sponsoring contracts. closes #84

niggl added the

status:review_needed

label 2021-02-28 15:36:23 +00:00

niggl self-assigned this 2021-02-28 15:36:23 +00:00

niggl added 9 commits 2021-02-28 15:36:24 +00:00

Basic sponsoring language dropdown for runners 6079e1fa90

ref #84

Working button onklicks 3b7c25b106

ref #48

Now with dropdown aiutoclose c89caf7855

ref #48

And with working i18n 🌍 e07d1e42e2

ref #48

Sorted translations 6870e31a81

ref #48

Moved pdf generation to function instead of onclick for all components 22e9f53c42

ref #48

Switched the icon style 305b18ef57

ref #84

New download buttons for everyone (that can generate sponsoring contracts) e24b84e709

ref #84

Removed locale overrides 9a8a978e49

ref #84

niggl requested review from philipp 2021-02-28 15:36:27 +00:00

philipp commented

2021-02-28 16:07:45 +00:00

Owner

don't know what exactly what I'm doing wrong but this issue appears when clicking on "Deutsch"

Also

maybe add the possibility to hide dropdown on "outside click" (click on page)
MUST: hide content when clicking the desired language download

currently, the content can only be hidden on dropdown button click

don't know what exactly what I'm doing wrong but this issue appears when clicking on "Deutsch" ![image](/attachments/a7af4cea-2398-45f3-b5e3-bc9fa00c1914) Also - [x] maybe add the possibility to hide dropdown on "outside click" (click on page) - [x] MUST: hide content when clicking the desired language download currently, the content can only be hidden on dropdown button click

20 KiB

philipp requested changes 2021-02-28 16:08:08 +00:00

philipp left a comment

Owner

see my comment ^^

see my comment ^^

niggl commented

2021-02-28 16:15:33 +00:00

Author

Owner

The issue from the sc hints at a wrong env.js kinfig (bs key is set).
Outside klick sounds good.
Autoclose is already implemented @runners, forgot to add it to the rest - thx for the hint :)

The issue from the sc hints at a wrong env.js kinfig (bs key is set). Outside klick sounds good. Autoclose is already implemented @runners, forgot to add it to the rest - thx for the hint :)

niggl referenced this issue from a commit

2021-02-28 16:17:43 +00:00

Clicking on a dropdown option now closes it everywhere

niggl added 1 commit 2021-02-28 16:17:46 +00:00

Clicking on a dropdown option now closes it everywhere 9fec315910

ref #84 #89

niggl added 1 commit 2021-02-28 16:39:26 +00:00

Implemented rough outside click handler for the dropdown c2bd696bfe

ref #84

niggl requested review from philipp 2021-02-28 16:50:18 +00:00

philipp approved these changes 2021-03-01 16:43:08 +00:00

philipp left a comment

Owner

thanks for the refinements 🤲

thanks for the refinements 🤲

niggl referenced this issue from a commit

2021-03-01 16:45:06 +00:00

Merge pull request 'Spnonsoring contract language selector feature/84-sponsoringcontract_language_selector' (#89) from feature/84-sponsoringcontract_language_selector into dev

niggl merged commit b810bb01db into dev

2021-03-01 16:45:07 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lfk/frontend#89

No description provided.