lfk/frontend
2
0
Fork 0
Code Issues 3 Pull Requests Actions Projects Releases Wiki Activity

Scan station management feature/93-scan_stations #95

Merged
niggl merged 33 commits from feature/93-scan_stations into dev 2021-03-15 15:55:30 +00:00
Conversation 4 Commits 33 Files Changed 12 +1533 -620
niggl commented 2021-03-10 17:19:20 +00:00
Owner
Copy Link

The title says it all!

You now can

  • View Scan Stations
  • Create new Scan Stations
  • Delete Scan Stations
  • Update scan stations

closes #93

The title says it all! You now can * View Scan Stations * Create new Scan Stations * Delete Scan Stations * Update scan stations closes #93
niggl added this to the Donations&Scans milestone 2021-03-10 17:19:20 +00:00
niggl added the
question
 label 2021-03-10 17:19:20 +00:00
niggl added 20 commits 2021-03-10 17:19:21 +00:00 
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
ref #93
niggl added 1 commit 2021-03-10 18:55:34 +00:00 
ref #93
niggl added 1 commit 2021-03-10 18:57:39 +00:00 
ref #93
niggl added 1 commit 2021-03-10 19:01:42 +00:00 
ref #93
niggl added 1 commit 2021-03-10 19:03:20 +00:00 
ref #93
niggl added 1 commit 2021-03-10 19:04:09 +00:00 
ref #93
niggl added 1 commit 2021-03-10 19:04:26 +00:00 
ref #93
niggl added
status:review_needed
 and removed
question
 labels 2021-03-10 19:05:17 +00:00
niggl requested review from philipp 2021-03-10 19:05:20 +00:00
niggl changed title from WIP: Scan station management feature/93-scan_stations to Scan station management feature/93-scan_stations 2021-03-10 19:05:27 +00:00
niggl added 1 commit 2021-03-10 19:06:41 +00:00 
ref odit/org#12 (comment)
philipp commented 2021-03-10 19:43:35 +00:00
Owner
Copy Link

so far so good 👍 a few notes:

margin-left is not needed imho - applies for AddScanStationModal + ScanStationDetail

image

spelling

"Bitte kopier den Token und bewahre ihn sicher auf!" --> "Bitte kopiere"
image

raw boolean values

could/ should be a ✅/❌? (sr-only might be needed for accessibility)
image

🥜 nitpick

add a cursor-pointer to the copy button?
image

so far so good 👍 a few notes: #### margin-left is not needed imho - applies for AddScanStationModal + ScanStationDetail ![image](/attachments/d267ec02-31d7-4b6c-bb12-9876a3445a47) #### spelling "Bitte kopier den Token und bewahre ihn sicher auf!" --> "Bitte kopier**e**" ![image](/attachments/04dbb40f-3b4c-4c05-9d98-32e0fae7cf2e) #### raw boolean values could/ should be a `✅`/`❌`? (`sr-only` might be needed for accessibility) ![image](/attachments/640e39d6-08f1-4247-bac5-48d111db7037) #### 🥜 nitpick add a `cursor-pointer` to the copy button? ![image](/attachments/e3b322c0-61f2-47f7-b793-8ed59ecc0dd3)
image.png
27 KiB
image.png
22 KiB
image.png
6.5 KiB
image.png
2.4 KiB
philipp requested changes 2021-03-10 19:43:55 +00:00
philipp left a comment
Owner
Copy Link

see my last comment

see my last comment
niggl added 1 commit 2021-03-12 17:17:10 +00:00 
#93
niggl added 1 commit 2021-03-12 17:20:38 +00:00 
ref #93
niggl added 1 commit 2021-03-12 17:21:42 +00:00 
ref #93 https://pointerpointer.com/
niggl added 1 commit 2021-03-12 17:23:56 +00:00 
ref #93
niggl requested review from philipp 2021-03-12 17:24:05 +00:00
niggl commented 2021-03-12 17:24:18 +00:00
Author
Owner
Copy Link

I implemented your suggestions :)

I implemented your suggestions :)
niggl added 1 commit 2021-03-12 17:55:43 +00:00
philipp approved these changes 2021-03-14 15:59:18 +00:00
philipp left a comment
Owner
Copy Link

👍thanks!

👍thanks!
niggl added 1 commit 2021-03-15 15:55:21 +00:00 
# Conflicts:
#	src/locales/de.json
niggl merged commit d00446dc7b into dev 2021-03-15 15:55:30 +00:00
niggl deleted branch 2021-03-15 15:55:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
philipp
Labels
Clear labels
bug
Something is not working
confirmed
The reported bug has been confirmed
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
priority:low
priority:medium
question
More information is needed
status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
status:review_needed
Milestone
No items
No Milestone Donations&Scans
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/frontend#95
No description provided.
Delete Branch "feature/93-scan_stations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?