lfk/frontend
2
0
Fork 0
Code Issues 4 Pull Requests Actions Projects Releases Wiki Activity

Scan station management feature/93-scan_stations #95

Merged
niggl merged 33 commits from feature/93-scan_stations into dev 2021-03-15 15:55:30 +00:00
Conversation 4 Commits 33 Files Changed 12 +1533 -620
niggl commented 2021-03-10 17:19:20 +00:00
Owner
Copy Link

The title says it all!

You now can

  • View Scan Stations
  • Create new Scan Stations
  • Delete Scan Stations
  • Update scan stations

closes #93

The title says it all! You now can * View Scan Stations * Create new Scan Stations * Delete Scan Stations * Update scan stations closes #93
niggl added this to the Donations&Scans milestone 2021-03-10 17:19:20 +00:00
niggl added the question label 2021-03-10 17:19:20 +00:00
niggl added 20 commits 2021-03-10 17:19:21 +00:00
Now routing scan statins overview ca9c390bb2 
ref #93
Added basic table for scanstations c53b579fca 
ref #93
Fixed nameing 5e417f0714 
ref #93
Fixed routing 891ea2da12 
ref #93
You can now add scanstations e45f8fa9ef 
ref #93
Basic scanstation creation 9ee768551f 
ref #93
Finished scanstationmodal (without i18n) 83e782c7c5 
ref #93
Finished scanstations base view 85fa9d942e 
ref #93
Changed row order 773fbfc579 
ref #93
Added station deletion confirmation dialog 9f754ef0e9 
ref #93
Now routing scan station detail a3daa2d24f 
ref #93
Added scanstation detail 258b3cea66 
ref #93
Spelling+Formatting 7ff1d50079 
ref #93
You can now delete a station from it's detail c4acf774ec 
ref #93
Added scanstations to sidebar 4b47e70b13 
ref #93
i18n run: Added keys 🌍 50aa891709 
ref #93
Added german translations e93f4e99f9 
ref #93
Sorted translations 👀 a5d1b76891 
ref #93
Added icon 🖼 e8e3ddceff 
ref #93
Fixed emptystate svg 870e772da2 
ref #93
niggl added 1 commit 2021-03-10 18:55:34 +00:00
Added station token copy modal 88566719ec 
ref #93
niggl added 1 commit 2021-03-10 18:57:39 +00:00
Added new translation keys 🌍 1aa2b3b065 
ref #93
niggl added 1 commit 2021-03-10 19:01:42 +00:00
Added german translations 🇩🇪 e6d80c8ccb 
ref #93
niggl added 1 commit 2021-03-10 19:03:20 +00:00
Added "tooltip" 2de861d4c1 
ref #93
niggl added 1 commit 2021-03-10 19:04:09 +00:00
Added german translation 🇩🇪 95fcd1dcc4 
ref #93
niggl added 1 commit 2021-03-10 19:04:26 +00:00
Sorted translations 74c042a86b 
ref #93
niggl added status:review_needed and removed question labels 2021-03-10 19:05:17 +00:00
niggl requested review from philipp 2021-03-10 19:05:20 +00:00
niggl changed title from WIP: Scan station management feature/93-scan_stations to Scan station management feature/93-scan_stations 2021-03-10 19:05:27 +00:00
niggl added 1 commit 2021-03-10 19:06:41 +00:00
Switched pipeline type to kubernetes ba9d4587cb 
ref odit/org#12 (comment)
philipp commented 2021-03-10 19:43:35 +00:00
Owner
Copy Link

so far so good 👍 a few notes:

margin-left is not needed imho - applies for AddScanStationModal + ScanStationDetail

image

spelling

"Bitte kopier den Token und bewahre ihn sicher auf!" --> "Bitte kopiere"
image

raw boolean values

could/ should be a ✅/❌? (sr-only might be needed for accessibility)
image

🥜 nitpick

add a cursor-pointer to the copy button?
image

so far so good 👍 a few notes: #### margin-left is not needed imho - applies for AddScanStationModal + ScanStationDetail ![image](/attachments/d267ec02-31d7-4b6c-bb12-9876a3445a47) #### spelling "Bitte kopier den Token und bewahre ihn sicher auf!" --> "Bitte kopier**e**" ![image](/attachments/04dbb40f-3b4c-4c05-9d98-32e0fae7cf2e) #### raw boolean values could/ should be a `✅`/`❌`? (`sr-only` might be needed for accessibility) ![image](/attachments/640e39d6-08f1-4247-bac5-48d111db7037) #### 🥜 nitpick add a `cursor-pointer` to the copy button? ![image](/attachments/e3b322c0-61f2-47f7-b793-8ed59ecc0dd3)
image.png
22 KiB
image.png
27 KiB
image.png
6.5 KiB
image.png
2.4 KiB
philipp requested changes 2021-03-10 19:43:55 +00:00
philipp left a comment
Owner
Copy Link

see my last comment

see my last comment
niggl added 1 commit 2021-03-12 17:17:10 +00:00
Spelling bd22d3be36 
#93
niggl added 1 commit 2021-03-12 17:20:38 +00:00
Fixed case sensitivity c6db6c5535 
ref #93
niggl added 1 commit 2021-03-12 17:21:42 +00:00
Added cursor-pointer 27a1f57ed3 
ref #93 https://pointerpointer.com/
niggl added 1 commit 2021-03-12 17:23:56 +00:00
Added fancier active states 95b1490f84 
ref #93
niggl requested review from philipp 2021-03-12 17:24:05 +00:00
niggl commented 2021-03-12 17:24:18 +00:00
Author
Owner
Copy Link

I implemented your suggestions :)

I implemented your suggestions :)
niggl added 1 commit 2021-03-12 17:55:43 +00:00
Merge branch 'dev' into feature/93-scan_stations e296256332
philipp approved these changes 2021-03-14 15:59:18 +00:00
philipp left a comment
Owner
Copy Link

👍thanks!

👍thanks!
niggl added 1 commit 2021-03-15 15:55:21 +00:00
Merge branch 'dev' into feature/93-scan_stations 40ada1c31e 
# Conflicts:
#	src/locales/de.json
niggl merged commit d00446dc7b into dev 2021-03-15 15:55:30 +00:00
niggl deleted branch 2021-03-15 15:55:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
philipp
Labels
Clear labels
priority:high
bug
Something is not working
 confirmed
The reported bug has been confirmed
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 priority:low
priority:medium
question
More information is needed
 status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Question
A question
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label status:review_needed
Milestone
No items
No Milestone Donations&Scans
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/frontend#95
Delete Branch "feature/93-scan_stations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?