lfk/mailer
3
0
Fork 0
Code Issues Pull Requests Actions Projects Releases 3 Wiki Activity

Welcome mails feature/2-welcome_mails #7

Merged
niggl merged 12 commits from feature/2-welcome_mails into dev 2021-03-04 15:51:13 +00:00
Conversation 3 Commits 12 Files Changed 9 +595 -9
niggl commented 2021-03-03 17:17:54 +00:00
Owner
Copy Link

The mailer can now send selfservice registration welcome mails.

closes #2

The mailer can now send selfservice registration welcome mails. closes #2
niggl added the
status:review_needed
 label 2021-03-03 17:17:54 +00:00
niggl added 8 commits 2021-03-03 17:17:55 +00:00
Added basic welcome mails b3f61f51e3 
ref #2
Added eventname to config a62f9c683d 
ref #2
Added all missing config vars/interpolations 4994cb0489 
ref #2
Merge branch 'dev' into feature/2-welcome_mails 425b27e124
Added german translations e2237d34d3 
ref #2
Added request class 056b74ce22 
ref #2
Added registration mail endpoint b3952c39e5 
ref #2
Added welcome mail tests
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ce87e1fc03 
ref #2
niggl requested review from philipp 2021-03-03 17:18:00 +00:00
niggl added a new dependency 2021-03-04 14:48:07 +00:00
#5 Send registration forgot mails
philipp reviewed 2021-03-04 15:35:33 +00:00
src/locales/de.json Outdated
@@ -18,0 +9,4 @@
"password-reset": "Passwort zurücksetzen",
"privacy": "Datenschutz",
"reset-password": "Passwort zurücksetzen",
"test-mail": "Test mail",
philipp commented 2021-03-04 15:35:33 +00:00
Owner
Copy Link

Backend groß ?

`Backend` groß ?
niggl marked this conversation as resolved
philipp requested changes 2021-03-04 15:41:58 +00:00
philipp left a comment
Owner
Copy Link

looks good so far 👍
src/templates/welcome_runner.txt should be translated, tho

also, we might need to do a i18n run together.

looks good so far 👍 `src/templates/welcome_runner.txt` should be translated, tho also, we might need to do a i18n run together.
niggl added 3 commits 2021-03-04 15:46:58 +00:00
Fixed typo 4b5e24f3e3 
ref #2
Added missing translations 1ec95a1fda 
ref #2
Sorted translations
All checks were successful
continuous-integration/drone/pr Build is passing
Details
18620133b9 
ref #2
niggl added 1 commit 2021-03-04 15:47:15 +00:00
Merge branch 'dev' into feature/2-welcome_mails
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6296457455
niggl requested review from philipp 2021-03-04 15:47:24 +00:00
philipp approved these changes 2021-03-04 15:51:04 +00:00
philipp left a comment
Owner
Copy Link

cool, thanks ✅

cool, thanks ✅
niggl merged commit 0b96dc8ba5 into dev 2021-03-04 15:51:12 +00:00
niggl deleted branch 2021-03-04 15:52:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
philipp
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
Work on this asap
priority:low
Do this when nothing else has to be done
priority:medium
Do this as soon as you have some spare time
question
More information is needed
status:blocked
This issue/pr is blocked
status:doing
This issue/pr is being worked on
status:review_needed
This issue/pr needs a review
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
status:review_needed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#5 Send registration forgot mails
lfk/mailer
Reference: lfk/mailer#7
No description provided.
Delete Branch "feature/2-welcome_mails"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?