lfk/scanclient
3
0
Fork 0
Code Issues Pull Requests Actions Projects Releases 19 Wiki Activity

feature/9-move-url-config-from-env-to-local-config #10

Merged
philipp merged 3 commits from feature/9-move-url-config-from-env-to-local-config into dev 2021-03-23 17:35:50 +00:00
Conversation 3 Commits 3 Files Changed 10 +121 -65
philipp commented 2021-03-22 18:34:16 +00:00
Owner
Copy Link

closes #9

closes #9
philipp added the
enhancement
 label 2021-03-22 18:34:16 +00:00
philipp added 2 commits 2021-03-22 18:34:17 +00:00 
ref #9
ref #9
philipp requested review from niggl 2021-03-22 18:34:20 +00:00
niggl commented 2021-03-23 15:51:32 +00:00
Owner
Copy Link

Please somehow specify that the "api endpoint" has to end with a slash (or better: automagicly™ add it when needed).

And just as a question (non blocking): Are you goint to document the config in this project's README or shall we incorporate it into lfk/docs (my favourite option)?

Screenshots

Input

image

Resulting Issue

image

Please somehow specify that the "api endpoint" has to end with a slash (or better: automagicly™ add it when needed). And just as a question (non blocking): Are you goint to document the config in this project's README or shall we incorporate it into lfk/docs (my favourite option)? # Screenshots ## Input ![image](/attachments/1ef24d6c-5229-4a8e-9069-b6a541744ab8) ## Resulting Issue ![image](/attachments/97a559cd-e42b-452c-9bb6-3d5ca4a2127d)
image.png
1.4 MiB
image.png
36 KiB
niggl refused to review 2021-03-23 15:54:00 +00:00
niggl commented 2021-03-23 15:54:57 +00:00
Owner
Copy Link

Hey @philipp I requested changes here: #10 (comment)

But i managed to remove my review rather than really requesting them by mistake :D

Hey @philipp I requested changes here: https://git.odit.services/lfk/scanclient/issues/10#issuecomment-4821 But i managed to remove my review rather than really requesting them by mistake :D
philipp added 1 commit 2021-03-23 17:11:58 +00:00 
ref #9
philipp requested review from niggl 2021-03-23 17:12:14 +00:00
niggl approved these changes 2021-03-23 17:25:42 +00:00
niggl left a comment
Owner
Copy Link

Thx 4 implementing the requested changes ✅👍

Thx 4 implementing the requested changes ✅👍
philipp merged commit db4d63da8b into dev 2021-03-23 17:35:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
niggl
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
Work on this asap
priority:low
Do this when nothing else has to be done
priority:medium
Do this as soon as you have some spare time
question
More information is needed
status:blocked
This issue/pr is blocked
status:doing
This issue/pr is being worked on
status:review_needed
This issue/pr needs a review
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/scanclient#10
No description provided.
Delete Branch "feature/9-move-url-config-from-env-to-local-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?