lfk/backend
2
0
Fork 0
Code Issues 1 Pull Requests Actions Projects Releases 40 Activity

Scan API #67

New Issue
Closed
opened 2020-12-31 16:41:17 +00:00 by niggl · 3 comments
niggl commented 2020-12-31 16:41:17 +00:00
Owner
Copy Link

We need api endpoints for scans (any type).

  • Get all scans
  • Get a single scan
  • Create a new scan (normal)
  • Update a scan's information
  • Delete a scan

And endpoints for the scan stations

  • Get all scan stations
  • Get a single scan station
  • Create a new scan station
  • Update a scan station's information
  • Delete a scan station

We also need test for all new endpoints:

  • scans get
  • scans add
  • scans update
  • scans delete
  • scanstations get
  • scanstations add
  • scanstations update
  • scanstations delete
We need api endpoints for scans (any type). * [x] Get all scans * [x] Get a single scan * [x] Create a new scan (normal) * [x] Update a scan's information * [x] Delete a scan And endpoints for the scan stations * [x] Get all scan stations * [x] Get a single scan station * [x] Create a new scan station * [x] Update a scan station's information * [x] Delete a scan station We also need test for all new endpoints: * [x] scans get * [x] scans add * [x] scans update * [x] scans delete * [x] scanstations get * [x] scanstations add * [x] scanstations update * [x] scanstations delete
niggl added this to the Donations&Scans milestone 2020-12-31 16:41:17 +00:00
niggl added the
priority:medium
enhancement
 labels 2020-12-31 16:41:17 +00:00
niggl referenced this issue from a commit 2021-01-03 17:48:08 +00:00
Added Scan permission target
niggl added the
status:doing
 label 2021-01-03 18:37:39 +00:00
niggl referenced this issue from a commit 2021-01-07 15:38:44 +00:00
Fixed scan runner in response
niggl referenced this issue from a commit 2021-01-07 16:03:41 +00:00
Implemented scan deletion
niggl added a new dependency 2021-01-07 17:59:36 +00:00
#76 Cleanup: Method nameing and folder sort
niggl commented 2021-01-07 18:09:00 +00:00
Author
Owner
Copy Link

I implemented most endpoints for the scanstations.

We have two options of "disableing" a scanstation:

  1. Just delete it -> This would mean that all scans created by this station would lose their scanstation association (which currently can't be null) aka they can't be traced back to that specific station any more
  2. Add a "enabled" flag -> This is the safe and easy route, but begs another question: Update this value via put (which shouldn't allow changeing anything but the enabled flag and description) or add a /disable route

Imo: We should go with 2. and a partial put.
@philipp What do you prefer?

I implemented most endpoints for the scanstations. We have two options of "disableing" a scanstation: 1. Just delete it -> This would mean that all scans created by this station would lose their scanstation association (which currently can't be null) aka they can't be traced back to that specific station any more 2. Add a "enabled" flag -> This is the safe and easy route, but begs another question: Update this value via put (which shouldn't allow changeing anything but the enabled flag and description) or add a /disable route Imo: We should go with 2. and a partial put. @philipp What do you prefer?
niggl referenced this issue from a commit 2021-01-07 18:18:28 +00:00
Added scan get tests
niggl referenced this issue from a commit 2021-01-07 18:19:22 +00:00
Added tmp files to gitignore
niggl referenced this issue from a commit 2021-01-07 18:36:59 +00:00
Fixed typo
niggl referenced this issue from a commit 2021-01-07 19:04:16 +00:00
Added scan station get tests
niggl referenced this issue from a commit 2021-01-07 19:16:17 +00:00
Added scan station add tests
niggl commented 2021-01-08 15:32:25 +00:00
Author
Owner
Copy Link

Since the creation of runnercards is a prequesite for trackscans i'm going to move all trackscans related tests and debugging to a new issue.

Since the creation of runnercards is a prequesite for trackscans i'm going to move all trackscans related tests and debugging to a new issue.
niggl added a new dependency 2021-01-08 15:36:53 +00:00
#77 Runner Cards
niggl commented 2021-01-08 15:37:52 +00:00
Author
Owner
Copy Link

The new issues are: #77 and #78

The new issues are: #77 and #78
niggl referenced this issue from a commit 2021-01-08 15:47:54 +00:00
Added scan delete tests
niggl referenced this issue from a commit 2021-01-08 16:27:57 +00:00
Added scan add tests
niggl referenced this issue from a commit 2021-01-08 16:42:07 +00:00
Added scan update tests
niggl referenced this issue from a commit 2021-01-08 17:37:34 +00:00
Updated comments
niggl referenced this issue from a commit 2021-01-08 18:34:40 +00:00
Finned node version for ci
niggl referenced this issue from a commit 2021-01-08 18:37:28 +00:00
Finned node version for ci
niggl closed this issue 2021-01-08 19:18:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
priority:low
priority:medium
question
More information is needed
status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
enhancement
priority:medium
status:doing
Milestone
No items
No Milestone Donations&Scans
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#76 Cleanup: Method nameing and folder sort
lfk/backend
#77 Runner Cards
lfk/backend
Reference: lfk/backend#67
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?