feature/108_vite_migration #118

Merged

philipp merged 27 commits from feature/108_vite_migration into dev 2021-04-03 17:17:25 +00:00

Conversation 9 Commits 27 Files Changed 28

+843 -837

philipp commented 2021-04-01 17:42:21 +00:00

Owner

Copy link

Copy source

This branch brings you

• ⚡ ViteJS
• 🍃 WindiCSS
• 🔨 Editor Tooling for TailwindCSS/ WindiCSS
• 🧹 Improved PostCSS (no PostCSS) via WindiCSS
• ✨ support for .svx files
• 🚀 faster dev + build times
• 💾 possibility to securely indefinitely cache assets (hash contents)
• 💾 fixed NGINX caching config
• ⏬ fully minified files for dist, including html
• 💻 proper VS Code DevContainer

💡 this should be a minor release because of possible breaking paths + caches

---

closes #108

This branch brings you - ⚡ ViteJS - 🍃 WindiCSS - 🔨 Editor Tooling for TailwindCSS/ WindiCSS - 🧹 Improved PostCSS (no PostCSS) via WindiCSS - ✨ support for `.svx` files - 🚀 faster dev + build times - 💾 possibility to securely indefinitely cache assets (hash contents) - 💾 fixed NGINX caching config - ⏬ fully minified files for dist, including html - 💻 proper VS Code DevContainer **💡 this should be a minor release because of possible breaking paths + caches** --- closes #108

philipp added the priority:highenhancement labels 2021-04-01 17:42:21 +00:00

philipp added 13 commits 2021-04-01 17:42:22 +00:00

basic ViteJS migration ... ae79e9fea1

ref #108

🐳 new Dockerfiles ... 0f32968fae

ref #108

updated default entrypoint ... 95c8fde72f

ref #108

for await fix - ViteJS ... aec5e3473e

ref #108

added windicss settings for VSCode ... 008027db0e

ref #108

package cleanup 6be2ee626a

⏫ bump vite to 2.1.3 ... 0cd3e937d8

ref #108

⏫📍 version bump + pin ... b065b4ff21

ref #108

⏫ version bumps ... d7fecfbd0b

ref #108

fix dev script ... eb3ede9593

ref #108

📃 added readme ... aa24b1dce5

ref #108

🔨 re-added VS Code devcontainer config ... 93187099d3

ref #108

⚡💾 prevent env.js from being cached ... c5d155396a

ref #108

niggl commented 2021-04-01 18:06:19 +00:00

Owner

Copy link

Copy source

@philipp You didn't request a review, but lemme say that dev looks fine and runs smooth+fast 🔥🔥🔥

Well fast except of the yarn install but that isn't your fault :D

@philipp You didn't request a review, but lemme say that dev looks fine and runs smooth+fast 🔥🔥🔥 Well fast except of the yarn install but that isn't your fault :D

niggl commented 2021-04-01 18:07:03 +00:00

Owner

Copy link

Copy source

But: Build in docker throws 404s

But: Build in docker throws 404s  

image.png

111 KiB

image.png

226 KiB

philipp added 1 commit 2021-04-02 19:07:02 +00:00

🐞 fix NGINX config ... 5352410d0c

ref #108

philipp added 1 commit 2021-04-02 19:07:21 +00:00

🐞 fix vite config for production system ... 10a011d842

ref #108

philipp added 1 commit 2021-04-02 19:19:31 +00:00

🧹 drop unused dependencies ... ce50fa2a62

ref #108

philipp added 1 commit 2021-04-02 19:19:51 +00:00

🐞 fix main.js linking ... 467404bfc8

ref #108

philipp added 1 commit 2021-04-02 19:20:08 +00:00

✨ update licenses.json ... e99e9e0708

ref #108

philipp added 1 commit 2021-04-02 19:20:51 +00:00

⏫ upgrade vite-plugin-windicss@0.12.1 ... ab45fc144e

ref #108

philipp added 2 commits 2021-04-02 19:57:00 +00:00

🚚 move @svitejs/vite-plugin-svelte to @sveltejs/vite-plugin-svelte ... 44b53da345

ref #108

🧹 reorder + fix package ... 12433f7c23

ref #108

philipp commented 2021-04-02 20:06:02 +00:00

Author

Owner

Copy link

Copy source

thanks for the heads up 👀
now including:

• 🐞 fixed build
• 🔨 AlpineJS Dev Container
• ⚡ Yarn PnP Auto-Install

thanks for the heads up 👀 now including: - 🐞 fixed build - 🔨 AlpineJS Dev Container - ⚡ Yarn PnP Auto-Install

philipp requested review from niggl 2021-04-02 20:06:07 +00:00

niggl commented 2021-04-03 07:18:15 +00:00

Owner

Copy link

Copy source

Yarn dev fails either loading building the stylesheets.

• Yarn build+live-server/vite yields the same results

Screenshots

Chrome

Firefox

Yarn dev fails either loading building the stylesheets. + Yarn build+live-server/vite yields the same results # Screenshots ## Chrome  ## Firefox 

image.png

41 KiB

image.png

135 KiB

niggl commented 2021-04-03 07:22:50 +00:00

Owner

Copy link

Copy source

Review - good:

• Dev container
• Docker build

Review - good: * Dev container * Docker build

niggl commented 2021-04-03 07:54:49 +00:00

Owner

Copy link

Copy source

I tried a local merge and now the import of a normal node module breaks stuff.
@philipp Tell me if you want me to push my merge

I tried a local merge and now the import of a normal node module breaks stuff. @philipp Tell me if you want me to push my merge 

image.png

7.2 KiB

niggl requested changes 2021-04-03 07:55:24 +00:00

niggl left a comment

Owner

Copy link

Copy source

Some things are still broken (reference: my comments)

Some things are still broken (reference: my comments)

philipp added 1 commit 2021-04-03 15:38:57 +00:00

🔨🔥 alpine based devcontainer with working yarn PnP ... 777304f259

ref #108

philipp added 1 commit 2021-04-03 16:22:03 +00:00

⏫ version bump: vite-plugin-windicss@0.12.2 ... 8d006d8c74

ref #108

niggl commented 2021-04-03 16:27:45 +00:00

Owner

Copy link

Copy source

Verified that local dev, build and docker all work now 🔥

Verified that local dev, build and docker all work now 🔥

philipp added 1 commit 2021-04-03 16:31:05 +00:00

🔨 dev container open ⚡ ... ceb2146c1b

ref #108

philipp requested review from niggl 2021-04-03 16:37:20 +00:00

niggl added a new dependency 2021-04-03 16:37:21 +00:00

#119 Certificate generation

philipp added 111 commits 2021-04-03 17:13:09 +00:00

Merge pull request 'first merge to main 🚀' (#71) from dev into main ... 9aa8e7edff

Reviewed-on: #71
Reviewed-by: Nicolai Ort <info@nicolai-ort.com>

Fixed dupliacate mutation 🐞 91dd5256e9

Merge branch 'dev' of git.odit.services:lfk/frontend into dev ca983c72d4

🚀RELEASE v0.8.5 e838e6f321

Added basic cards page ... 5c5ef95d2b

ref #94

Added CardsEmptyState + Emtystate graphic ... 2d0beaaaad

ref #94

Added basic card overview ... c6a15264b3

ref #94

Now routing the cards page ... e852305400

ref #94

Now importing runner overview ... 77e9c205f9

ref #94

Formatting ... a516aa7775

ref #94

Added message for missing runner/blanco card) ... 4715978f81

ref #94

Implemented Add card modal ... 535b23ae91

ref #94

Added bulk card creation modal ... 8a32569a3b

ref #94

Added bulk creation modal to cards view ... f46ccb610e

ref #94

Bumped lfk client lib version ... 3cd0468b19

ref #94

Implemented bulk creation ... 7ad6b73574

ref #94

Added runnercard detail/edit modal ... 0313f8cc49

ref #94

Now w/working editing ... fac059f02c

ref #94

Fixed mail login bug🐞📧 ... 076893981f

ref #107

Commented out the buggy runner search to prevent bad UX ... fbe74a5d80

ref #107

Fixed outsideclick not clearing import modal🛠 ... ef49e507c1

ref #107

Fixed runner import getting triggered with invalid information ... ddd9c396b6

ref #107

Errors now toast errors❌ ... 17e0805fe6

ref #107

Sorted translations🌍 ... a1ab65a0e9

ref #107

Fixed missing translations for scanstations🌍 ... aeadef60bb

ref #107

Sorted translations 👀 ... 82b1811971

ref #107

Fixed conflicting css ... 50fffef13b

ref #107

Now disabled search by middlename as a quick workaround 🐞 ... 49e87ccb15

ref #107

Removed middlename search from all files that had it ... 6b92405bae

ref #107

Merge pull request 'Know Production Bugs 🐞' (#109) from bugfix/107-prod_issues into dev ... d2050b5948

Reviewed-on: #109

🚀RELEASE v0.8.6 c3c95bf291

Sorted translations ... de2fe0e9f1

ref #94

Merge branch 'dev' into feature/94-runnercard_mgnt ... 983ce56048

# Conflicts:
#	src/locales/de.json
#	src/locales/en.json

Sorted translations 🌍 ... d6c315ab8e

ref #94

Moved modal import to overview for simplification ... 1a52aaf8d1

ref #94

Now w/ working dialog🎉🎉🎉 ... ae9673070c

ref #94

Moved contract generation to it's own component ... 0cfc87fbe6

ref #94

Orgs now use the new sponsoring contracts module ... 8b451b3c67

ref #94

Fixed org generation not hiding the generation toast ... c87321f804

ref #94

Teams now use the new sponsoring contracts module ... 014ba3bf67

ref #94

Moved the pdf generation related componenets to their own folder ... ddd82a71a7

ref #94

Formatting ... 9f7d2234fb

ref #94

Fixed listen on wrong permission🐞 08442154f4

🚀RELEASE v0.8.7 0af2647965

Merge branch 'dev' into feature/94-runnercard_mgnt ec447e2e36

Fuggin snowpack bs ... 44bc14820f

ref #94

Basic card generation worX 🎉🎉 ... d467475b6d

ref #94

Removed debug info ... 55693de934

ref #94

Added translations ... 6b5945add8

ref #94

Working runner runnercard generation ... c907486c4d

ref #94

Added runnercard generation for teams ... 23e0b53107

ref #94

Now with working org runenrcard generation ... 4b3d38b05b

ref #94

Fixed counting bug ... f5c1ec9939

ref #94

Added a new runenrcard logo ... acf78a8822

ref #94

Added card generation/printing from detail ... 4a36fb6d95

ref #94

Sorted translations 🌍 ... 1665a1a093

ref #94

✒ typo - "Geb" -> "Gebe" ... f794af0950

ref #94

drop console log - CardDetailModal ... 40899e9d80

ref #94

CardsOverview - move to 'enabled' language key ... df53c07450

ref #94

Merge pull request 'Runner cards feature/94-runnercard_mgnt' (#111) from feature/94-runnercard_mgnt into dev ... 2932f4591e

Reviewed-on: #111

🚀RELEASE v0.9.0 67c3732fad

new license file version [CI SKIP] ded9b589fe

Merge branch 'dev' of git.odit.services:lfk/frontend into dev 48506236bf

Merge branch 'main' into dev bc36411993

Added checkbox to enable registration ... f9fe793573

ref #112

You can now copy the selfservice links to your clipboard ... fcd55f89d7

ref #112

Fixed changes in wrong file ... 73d95bc004

ref #112

Formatting ... f185d559c0

ref #112

Added check if key exists 2316baa898

Added check if key exists ... c2d29ff233

ref #112

Merge branch 'feature/112-org_registration_links' of git.odit.services:lfk/frontend into feature/112-org_registration_links 38e1c8c5a1

Copy now 100% worX ... a3921b45c7

ref #112

Added translations ... ddbc293e9c

ref #112

Sorted translations ... c074c12be7

ref #112

Implemented a custom password strength component ... 4956bb0e9c

ref #106

Added more cirteria to the password strength component ... 5fa9939696

ref #106

Added a password strength verification ... ad3bd312e9

ref #106

Now using pw strength component ... 6aaf838451

ref #106

Now using pw strength component for reset ... 5d5f7c7f5c

ref #106

Added missing exports ... 962dd0c1bb

ref #106

Now using pw strength component for user creation ... 7862f44653

ref #106

Module now exports functions that check if a password is strong enough and equal to a potential confirmation field ... b2509e9e53

ref #106

Reset can now only be triggered if pw is strong enoug ... 75d8f7331b

ref #106

User creation can now only be triggered if pw is strong enoug ... 540304f947

ref #106

Added translations ... 79c447b4c6

ref #106

Sorted translations 🌍 ... 5bd3a463f0

ref #106

Formatting🛠 ... 4167819e7a

ref #106

Merge pull request 'Org selfservice Link feature/112-org_registration_links' (#114) from feature/112-org_registration_links into dev ... a5d25e7d92

Reviewed-on: #114

🚀RELEASE v0.9.1 2ca63fd1f6

Merge branch 'dev' into feature/106-password_strength f1e6fb4ce7

Merge pull request 'Implemented password strength test feature/106-password_strength' (#115) from feature/106-password_strength into dev ... 09b8144080

Reviewed-on: #115

new license file version [CI SKIP] 34f4f68524

Bumped lfk-client version 🔝 cf58bd15c3

new license file version [CI SKIP] aedb8a765b

🚀RELEASE v0.10.0 f7fc1967a5

Added function for generating cards with pdf ... c8d639024a

ref #116

Added comment ... 636f018daa

ref #116

Added button (including translations ... 97e338f9d4

ref #116

Added button (including translations ... 0614c76e92

ref #116

Merge branch 'feature/116-download_blanc_cards' of git.odit.services:lfk/frontend into feature/116-download_blanc_cards ... 450aa83592

# Conflicts:
#	src/components/cards/AddCardBulkModal.svelte

Fixed button styling ... 08cb079e97

ref #116

Bumped lfk-client-js ... 7dfaa7579a

ref #116

Now returning cards on creation with pdf ... 1d999d4910

ref #116

Bumped lfk client js version ... 2d18686ce7

ref #116

Sorted translations ... 89bb9c215e

ref #116

Merge pull request 'Generate and print bulk blank cards feature/116-download_blanc_cards' (#117) from feature/116-download_blanc_cards into dev ... 25d8b86efd

Reviewed-on: #117

🚀RELEASE v0.11.0 f8ccf4f5d8

new license file version [CI SKIP] 8f8b9988ad

Merge branch 'dev' of git.odit.services:lfk/frontend into dev 87370d24be

Merge branch 'dev' into feature/108_vite_migration ... d966e1d4de

# Conflicts:
#	index.html
#	package.json
#	public/licenses.json
#	src/App.svelte
#	src/components/orgs/OrgOverview.svelte
#	src/components/teams/TeamsOverview.svelte

🐞 fix await for esNext ... a9227768de

ref #108

niggl approved these changes 2021-04-03 17:15:22 +00:00

niggl left a comment

Owner

Copy link

Copy source

🔥🚀🌑

🔥🚀🌑

philipp added 1 commit 2021-04-03 17:16:55 +00:00

⏫ bump @odit/lfk-client-js@0.10.1 ... 8b74d6d759

ref #108

philipp merged commit c8cfe669b8 into dev 2021-04-03 17:17:24 +00:00

philipp referenced this issue from a commit 2021-04-03 17:17:24 +00:00

Merge pull request 'feature/108_vite_migration' (#118) from feature/108_vite_migration into dev

Sign in to join this conversation.

Reviewers

No Reviewers

niggl

Labels

Clear labels

priority:high

bug

Something is not working

confirmed

The reported bug has been confirmed

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

priority:low

priority:medium

question

More information is needed

status:blocked

status:doing

status:review_needed

wontfix

This won't be fixed

Kind/Bug

Something is not working

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Question

A question

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Status/Confirmed

This is indeed a bug/issue

Complexity

Easy

The complexity is low

Complexity

Hard

The complexity is high

Complexity

Medium

The complexity is medium

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Doing

Somebody is working on this

Status

Need More Info

Feedback is required to reproduce issue or to continue work

Status

Review needed

Needs a reveiw

No labels priority:high enhancement

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

niggl (Nicolai Ort) philipp (Philipp Dormann)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Blocks

#119 Certificate generation

lfk/frontend

Reference: lfk/frontend#118