lfk/selfservice
3
0
Fork 0
Code Issues Pull Requests Actions Projects Releases Wiki Activity

feature/30-profile-forgot-link #35

Merged
philipp merged 6 commits from feature/30-profile-forgot-link into dev 2021-04-02 19:00:52 +00:00
Conversation 4 Commits 6 Files Changed 4 +149 -32
philipp commented 2021-04-01 17:23:49 +00:00
Owner
Copy Link

close #30

close #30
philipp added 3 commits 2021-04-01 17:23:49 +00:00 
ref #30
ref #30
ref #30
philipp requested review from niggl 2021-04-01 17:23:55 +00:00
philipp added the
enhancement
 label 2021-04-01 17:23:58 +00:00
niggl commented 2021-04-01 17:50:13 +00:00
Owner
Copy Link

Hey you're sending the mail in a bad format.
It should be /runners/forgot?mail=mail@me.lelel&locale=de

image

Hey you're sending the mail in a bad format. It should be /runners/forgot?mail=mail@me.lelel&locale=de ![image](/attachments/4e97adb7-17f0-4735-9b19-b9cd7895294b)
image.png
14 KiB
image.png
14 KiB
image.png
niggl requested changes 2021-04-01 17:50:26 +00:00
niggl left a comment
Owner
Copy Link

See: My comment

See: My comment
niggl added 1 commit 2021-04-01 17:55:05 +00:00 
ref #30
niggl added 1 commit 2021-04-01 17:55:27 +00:00 
ref #30
niggl added 1 commit 2021-04-01 17:58:43 +00:00 
# Conflicts:
#	src/locales/en.json
#	src/views/Home.vue
niggl commented 2021-04-01 18:00:25 +00:00
Owner
Copy Link

Sadly I can't re-request myself for a review.
Soo either re-request my review or take this as confirmation and approval.

Sadly I can't re-request myself for a review. Soo either re-request my review or take this as confirmation and approval.
philipp requested review from niggl 2021-04-02 11:55:12 +00:00
niggl approved these changes 2021-04-02 11:56:09 +00:00
niggl left a comment
Owner
Copy Link

Works ✅

Works ✅
philipp merged commit cd6a139daf into dev 2021-04-02 19:00:52 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
niggl
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
priority:high
Work on this asap
priority:low
Do this when nothing else has to be done
priority:medium
Do this as soon as you have some spare time
question
More information is needed
status:blocked
This issue/pr is blocked
status:doing
This issue/pr is being worked on
status:review_needed
This issue/pr needs a review
wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Question
A question
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/selfservice#35
No description provided.
Delete Branch "feature/30-profile-forgot-link"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?