lfk/selfservice
3
0
Fork 0
Code Issues Pull Requests Actions Projects Releases Wiki Activity

feature/3_env_file #9

Merged
philipp merged 6 commits from feature/3_env_file into dev 2021-03-05 18:09:16 +00:00
Conversation 3 Commits 6 Files Changed 16 +181 -10
philipp commented 2021-03-04 18:58:33 +00:00
Owner
Copy Link

image

![image](/attachments/b423b14e-bc70-4282-b584-772ec48675c2)
image.png
23 KiB
philipp added the enhancementpriority:medium labels 2021-03-04 18:58:33 +00:00
philipp added 4 commits 2021-03-04 18:58:34 +00:00
✨ basic env.js file for api baseurl, documentserver_key 747c1d2a90 
ref #3
basic markdown rendering + routing for /imprint and /privacy 5a5261d6b0 
ref #3
fallback for env config errors 20229ab142 
ref #3
added ui for configuration errors page c92d5bf5f2 
ref #3
philipp requested review from niggl 2021-03-04 18:58:52 +00:00
niggl commented 2021-03-05 17:09:07 +00:00
Owner
Copy Link

Nitpicks

Some kind of documentation about the env.js file in the README would be highly appreciated.

Errors

I dont get the error page when no env is set

image

## Nitpicks Some kind of documentation about the env.js file in the README would be highly appreciated. ## Errors I dont get the error page when no env is set ![image](/attachments/a3ed11c5-1473-4e69-a2c7-1acb05fd1dd4)
image.png
124 KiB
niggl requested changes 2021-03-05 17:10:49 +00:00
niggl left a comment
Owner
Copy Link

#9 (comment)

Otherwise everything seems fine as far as I tested

https://git.odit.services/lfk/selfservice/issues/9#issuecomment-4115 Otherwise everything seems fine as far as I tested
philipp added 1 commit 2021-03-05 17:47:20 +00:00
🐞 bugfix for non-existant env.js 987ac4d02c 
ref #3
philipp added 1 commit 2021-03-05 17:59:27 +00:00
📃 updated README 4c78712f83 
ref #3
philipp requested review from niggl 2021-03-05 18:02:38 +00:00
niggl approved these changes 2021-03-05 18:03:48 +00:00
niggl left a comment
Owner
Copy Link

Thanks for documenting stuff in the readme ^_-

Thanks for documenting stuff in the readme ^_-
philipp merged commit b668c50eac into dev 2021-03-05 18:09:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
niggl
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 priority:high
Work on this asap
 priority:low
Do this when nothing else has to be done
 priority:medium
Do this as soon as you have some spare time
 question
More information is needed
 status:blocked
This issue/pr is blocked
 status:doing
This issue/pr is being worked on
 status:review_needed
This issue/pr needs a review
 wontfix
This won't be fixed
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Kind/Bug
Something is not working
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Question
A question
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status/Confirmed
This is indeed a bug/issue
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No Label enhancement priority:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
niggl odit_bot philipp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfk/selfservice#9
Delete Branch "feature/3_env_file"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?