lfk
/
selfservice
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feature/3_env_file #9

Merged
philipp merged 6 commits from feature/3_env_file into dev 2021-03-05 18:09:16 +00:00
Conversation 1 Commits 6 Files Changed 16 +181 -10
philipp commented 2021-03-04 18:58:33 +00:00
Owner
Copy Link

image

![image](/attachments/b423b14e-bc70-4282-b584-772ec48675c2)
image.png
23 KiB
philipp added the
enhancement
priority:medium
 labels 2021-03-04 18:58:33 +00:00
philipp added 4 commits 2021-03-04 18:58:34 +00:00
philipp requested review from niggl 2021-03-04 18:58:52 +00:00
niggl commented 2021-03-05 17:09:07 +00:00
Owner
Copy Link

Nitpicks

Some kind of documentation about the env.js file in the README would be highly appreciated.

Errors

I dont get the error page when no env is set

image

## Nitpicks Some kind of documentation about the env.js file in the README would be highly appreciated. ## Errors I dont get the error page when no env is set ![image](/attachments/a3ed11c5-1473-4e69-a2c7-1acb05fd1dd4)
image.png
124 KiB
niggl requested changes 2021-03-05 17:10:49 +00:00
niggl left a comment
Owner
Copy Link

#9 (comment)

Otherwise everything seems fine as far as I tested

https://git.odit.services/lfk/selfservice/issues/9#issuecomment-4115 Otherwise everything seems fine as far as I tested
philipp added 1 commit 2021-03-05 17:47:20 +00:00
philipp added 1 commit 2021-03-05 17:59:27 +00:00
philipp requested review from niggl 2021-03-05 18:02:38 +00:00
niggl approved these changes 2021-03-05 18:03:48 +00:00
niggl left a comment
Owner
Copy Link

Thanks for documenting stuff in the readme ^_-

Thanks for documenting stuff in the readme ^_-
philipp merged commit b668c50eac into dev 2021-03-05 18:09:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
niggl
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority:high

Work on this asap

  
priority:low

Do this when nothing else has to be done

  
priority:medium

Do this as soon as you have some spare time

  
question

More information is needed

  
status:blocked

This issue/pr is blocked

  
status:doing

This issue/pr is being worked on

  
status:review_needed

This issue/pr needs a review

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
priority:high
priority:low
priority:medium
question
status:blocked
status:doing
status:review_needed
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lfk/selfservice#9
No description provided.
Delete Branch "feature/3_env_file"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?