Nicolai Ort niggl
1 Followers · 1 Following
Repositories
5
 Projects Packages Public Activity Starred Repositories
2
niggl suggested changes for lfk/frontend#118 2021-04-03 07:55:24 +00:00
feature/108_vite_migration

Some things are still broken (reference: my comments)

niggl commented on pull request lfk/frontend#118 2021-04-03 07:54:49 +00:00
feature/108_vite_migration

I tried a local merge and now the import of a normal node module breaks stuff. @philipp Tell me if you want me to push my merge

image

niggl commented on pull request lfk/frontend#118 2021-04-03 07:22:50 +00:00
feature/108_vite_migration

Review - good:

  • Dev container
  • Docker build
niggl commented on pull request lfk/frontend#118 2021-04-03 07:18:15 +00:00
feature/108_vite_migration

Yarn dev fails either loading building the stylesheets.

Screenshots

Chrome

image

##…

niggl approved lfk/selfservice#35 2021-04-02 11:56:09 +00:00
feature/30-profile-forgot-link

Works ✅

niggl commented on pull request lfk/frontend#118 2021-04-01 18:07:03 +00:00
feature/108_vite_migration

But: Build in docker throws 404s

image image

niggl commented on pull request lfk/frontend#118 2021-04-01 18:06:20 +00:00
feature/108_vite_migration

@philipp You didn't request a review, but lemme say that dev looks fine and runs smooth+fast 🔥🔥🔥

Well fast except of the yarn install but that isn't your fault :D

niggl commented on pull request lfk/selfservice#35 2021-04-01 18:00:25 +00:00
feature/30-profile-forgot-link

Sadly I can't re-request myself for a review. Soo either re-request my review or take this as confirmation and approval.

niggl pushed to feature/30-profile-forgot-link at lfk/selfservice 2021-04-01 17:58:41 +00:00
ec44a8b63e Merge branch 'dev' into feature/30-profile-forgot-link
676f0e8339 🚀Bumped version to v0.5.0
27fd8f9a91 Revert "🚀Bumped version to v0.5.0"
bc1c824d9f Merge branch 'dev' of git.odit.services:lfk/selfservice into dev
b8c1b8c43b 🚀Bumped version to v0.5.0
Compare 20 commits »
niggl pushed tag 0.5.0 to lfk/selfservice 2021-04-01 17:57:19 +00:00
niggl pushed to dev at lfk/selfservice 2021-04-01 17:57:10 +00:00
676f0e8339 🚀Bumped version to v0.5.0
27fd8f9a91 Revert "🚀Bumped version to v0.5.0"
bc1c824d9f Merge branch 'dev' of git.odit.services:lfk/selfservice into dev
b8c1b8c43b 🚀Bumped version to v0.5.0
Compare 4 commits »
niggl pushed to feature/30-profile-forgot-link at lfk/selfservice 2021-04-01 17:55:25 +00:00
713db5e1e8 Removed useless code
niggl pushed to feature/30-profile-forgot-link at lfk/selfservice 2021-04-01 17:55:04 +00:00
0795ea318d Fixed post url and body
niggl closed issue lfk/selfservice#21 2021-04-01 17:52:16 +00:00
user deletion
niggl deleted branch feature/21-user_deletion from lfk/selfservice 2021-04-01 17:52:06 +00:00
niggl merged pull request lfk/selfservice#36 2021-04-01 17:50:44 +00:00
Runner self deletion feature/21-user_deletion
niggl pushed to dev at lfk/selfservice 2021-04-01 17:50:42 +00:00
bd512e0651 Merge pull request 'Runner self deletion feature/21-user_deletion' (#36) from feature/21-user_deletion into dev
cf0437c3a7 Sorted translations
8a24505d64 Added translations
175bb168ae Content i18n run 🌍
9751c2e9fd Added error toast
Compare 13 commits »
niggl suggested changes for lfk/selfservice#35 2021-04-01 17:50:26 +00:00
feature/30-profile-forgot-link

See: My comment

niggl commented on pull request lfk/selfservice#35 2021-04-01 17:50:13 +00:00
feature/30-profile-forgot-link

Hey you're sending the mail in a bad format. It should be /runners/forgot?mail=mail@me.lelel&locale=de

image

niggl created pull request lfk/selfservice#36 2021-04-01 17:44:18 +00:00
Runner self deletion feature/21-user_deletion