lfk/backend
2
0
Fork 0
Code Issues 1 Pull Requests Actions Projects Releases 40 Activity

bugfix/68-address_circular_dependencies #70

Merged
niggl merged 5 commits from bugfix/68-address_circular_dependencies into feature/65-donor_controllers 2021-01-02 20:55:04 +00:00
Conversation 1 Commits 5 Files Changed 10
+52 -39
niggl commented 2021-01-02 19:04:53 +00:00
Owner
Copy Link
Copy Source

Please review. The implementation of the bugfix is... Creative so please check if that solution is ok w/ you.

Please review. The implementation of the bugfix is... Creative so please check if that solution is ok w/ you.
niggl added 4 commits 2021-01-02 19:04:53 +00:00
Implemented a possible bugfix 2c47436259 
ref #68
Added comments to the bugfix 9c4e54fc6e
Revert "Removed addresses from tests until the circular dependencies are solved" 56c6a7efb0 
This reverts commit 599296c4e3.
Reenabled addresses in org responses
continuous-integration/drone/pr Build is passing
Details
1e2de7656e 
ref #68
niggl added a new dependency 2021-01-02 19:05:08 +00:00
#69 New Feature: Donor endpoints feature/65-donor_controllers
niggl requested review from philipp 2021-01-02 19:05:21 +00:00
niggl referenced this issue from a commit 2021-01-02 20:53:21 +00:00
Change requested by @philipp
niggl added 1 commit 2021-01-02 20:53:24 +00:00
Change requested by @philipp
continuous-integration/drone/pr Build is passing
Details
97e8470b0d 
ref #70
philipp approved these changes 2021-01-02 20:54:48 +00:00
niggl merged commit 92186a86cc into feature/65-donor_controllers 2021-01-02 20:55:04 +00:00
niggl deleted branch 2021-01-02 20:55:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
philipp
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 priority:high
priority:low
priority:medium
question
More information is needed
 status:blocked
status:doing
status:review_needed
wontfix
This won't be fixed
Kind/Bug
Something is not working
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Question
A question
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Status/Confirmed
This is indeed a bug/issue
Complexity
Easy
The complexity is low
Complexity
Hard
The complexity is high
Complexity
Medium
The complexity is medium
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Doing
Somebody is working on this
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Status
Review needed
Needs a reveiw
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
niggl (Nicolai Ort) philipp (Philipp Dormann)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#69 New Feature: Donor endpoints feature/65-donor_controllers
lfk/backend
Reference: lfk/backend#70